Skip to content

Respect addBuildEnvironmentEntries for Build-Jdk-Spec#544

Open
goutamadwant wants to merge 1 commit into
apache:masterfrom
goutamadwant:fix/mjar-539-build-environment-entries
Open

Respect addBuildEnvironmentEntries for Build-Jdk-Spec#544
goutamadwant wants to merge 1 commit into
apache:masterfrom
goutamadwant:fix/mjar-539-build-environment-entries

Conversation

@goutamadwant

Copy link
Copy Markdown

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Fixes #539.

Summary

This makes the JAR plugin pass archive.manifest.addBuildEnvironmentEntries through to Maven Archiver's Build-Jdk-Spec default-entry switch.

When build environment entries are disabled, Build-Jdk-Spec is now omitted along with the other build-environment manifest entries. Normal manifest entries such as Main-Class and the detected Java-Version remain in place.

Tests

  • mvn -Prun-its -Dinvoker.test=MJAR-539-build-environment-entries verify
  • mvn verify
  • mvn -Prun-its verify

Disable the Maven Archiver Build-Jdk-Spec default entry when archive manifest build environment entries are disabled.

Add an MJAR-539 integration test covering the modular jar path and verifying build environment manifest entries stay absent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reproducible builds violation: Build-Jdk-Spec and Build-Tool-Jdk-Spec manifest entries cannot be excluded

1 participant