fix(storage): ignore invalid ancestor Git markers - #4807
Open
faga295 wants to merge 1 commit into
Open
Conversation
Generated-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ignore structurally invalid
.gitentries in strict ancestors when classifying a selected folder, while preserving fail-closed behavior for a malformed.gitentry in the selected folder itself. Valid Git directories,gitdir:indirection files, repositories, and linked worktrees continue to resolve normally.Add regression coverage for Project Catalog classification and workspace identity marker publication.
Fixes #4806
Verification
npm --workspace @maka/storage run buildnpm --workspace @maka/storage run typechecknpm --workspace @maka/storage run test:dist— 1,112 passed, 8 skipped, 0 failednpx biome check packages/storage/src/git-entry.ts packages/storage/src/__tests__/project-catalog.test.ts packages/storage/src/__tests__/workspace-identity.test.tsnpm run check:asf-headerskind: 'folder'AI use
Select exactly one:
Tool(s) and scope: OpenAI Codex — root-cause analysis, implementation, regression tests, verification, and PR drafting.
Checklist
Does this PR entail a change in behavior?