test(desktop): move P1 journeys off Electron - #4803
Draft
Astro-Han wants to merge 1 commit into
Draft
Conversation
Generated-by: Codex
Astro-Han
force-pushed
the
test/4761-move-p1-e2e
branch
from
September 4, 2026 18:06
e1ed74b to
906c124
Compare
Astro-Han
marked this pull request as draft
September 4, 2026 18:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 3 of #4761 moves the remaining 20 P1 assertions out of Electron. Ten E2E files are deleted in the same change that establishes or identifies their lower-tier owners. Playwright now lists 58 tests in 25 files, down from 78 tests in 35 files on the merged PR 2 baseline.
app-shell-revision-actions.test.tsand the conversation-owned retirement helpergoal-dialog.test.tsImeCommitDoesNotSendStorybook interactionSessionSwitchRenderBudgetStorybook interactionAboutstory interactionThe only production refactor is revision-draft retirement: the same child/source cleanup was used in two AppShell paths, so it now has one conversation-owned function and a direct unit contract. The architecture ledger decreases by one import specifier and one non-trivia token.
The Session rail replacement retains the two-row touch budget, zero remounts, direct selection transition, and zero status rebuilds. Static Storybook consistently performs one extra ref pair during focus handoff, so its inline-style ceiling is 10 rather than Electron's 8; the fixture-independent two-row bound remains the primary regression gate.
Refs #4761
Verification
npm --workspace @maka/desktop run build-storybooknpm --workspace @maka/desktop run smoke:storybook— 292 stories / 318 theme renders, passednpm --workspace @maka/ui run typecheck— passednpm --workspace @maka/desktop run check:architecture— passedorigin/main— passednpm run lint— passednpm run format:check— passednode scripts/asf-license-headers.mjs check— passednpx playwright test --config apps/desktop/e2e/playwright.config.ts --list— 58 tests in 25 filesNot run: the full Electron E2E suite. This change removes tests from that tier and does not change its remaining fixtures.
Review focus
AI use
Select exactly one:
Tool(s) and scope: Codex — mapped the removed E2E assertions to their owning lower tiers, added the replacement stories and unit contracts, ran the validation above, and drafted this description. The commit carries a
Generated-by: Codextrailer.Checklist
Does this PR entail a change in behavior?