docs: audit Tools and capabilities group against implementation - #4799
Open
ggbdpq wants to merge 1 commit into
Open
docs: audit Tools and capabilities group against implementation#4799ggbdpq wants to merge 1 commit into
ggbdpq wants to merge 1 commit into
Conversation
Audit the three Tools and capabilities documents from the apache#3522 documentation audit against the current implementation (22715e8). mcp-runtime-architecture-draft.zh-CN.md: the load-bearing contracts resolve as written (tool naming mcp__{server}__{tool} with the 64-char hash suffix, categoryHint network_send default, the 30s/60s/15s/600s timeout matrix, the stdio env allowlist, the four package boundaries). The PermissionEngine mention is the one the tracking issue already verified as correct. No drift; added the standard frontmatter. skill-catalog-policy.md: every named symbol resolves, and the budget constants match the code exactly (MAX_SKILLS_PROMPT_CHARS 18000, MIN/MAX_SKILLS_PROMPT_TOKENS 4_000/8_000, SKILLS_PROMPT_CONTEXT_RATIO 0.02). No drift; added the standard frontmatter. web-search-provider-capability.md: one drift fixed — the execution surfaces table still listed the retired Headless Harbor surface and its MAKA_WEB_SEARCH_ENABLED opt-in, which apache#2605 removed on 2026-08-11 when Headless became the minimal Eval kernel; the row now records the retirement instead of presenting the surface as current. The rest verifies (routeWebSearchTools, model-web-search.ts, providerExecuted replay, the DeepSeek V4 Flash anthropic-compatible rule). Added the standard frontmatter. Refs apache#3522 Generated-by: GLM-5.3-Flash (ZCode)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audits the Tools and capabilities group (3 documents) from #3522 against the current implementation (22715e8).
docs/architecture/mcp-runtime-architecture-draft.zh-CN.md— no drift. Load-bearing contracts resolve as written: tool namingmcp__{serverId}__{toolName}with the 64-char hash-suffix rule (mcp-tools.ts:224), thecategoryHint: network_senddefault (mcp-tools.ts:141), the 30s/60s/15s/600s timeout matrix (packages/mcp/src/index.ts:125-128), the stdio env allowlist withLC_*/XDG_*prefixes (index.ts:2422-2433), and the four package boundaries. ItsPermissionEnginemention is the one the tracking issue already verified as correct.docs/skill-catalog-policy.md— no drift. All named symbols resolve (selectSkillsForContext,SkillSelectionReportdecision values,BUNDLED_SKILL_CATALOG,prepareSkillInvocationMessage,SkillInvocationReceipt,too_many_requests,SkillSearch,blocked_path/read_failed,.maka/skills-state.jsonv2 withneedsReview), and the budget constants match the code exactly (skills-context.ts:50-53).docs/web-search-provider-capability.md— one drift fixed: the execution-surfaces table still listed the retired Headless Harbor surface and itsMAKA_WEB_SEARCH_ENABLED=trueopt-in. That env var was introduced by feat(search): add provider-native web search #2152 (2026-08-05) and removed by refactor: replace Headless with minimal Eval kernel #2605 (2026-08-11) when Headless became the minimal Eval kernel; on the current tree it exists only in this document. The row now records the retirement, and the opt-in rationale is reworded to apply to eval subjects. Everything else verifies (routeWebSearchTools,packages/core/src/model-web-search.ts,providerExecutedreplay, the DeepSeek V4 Flash anthropic-compatible rule);web_search_20250305lives in the conformance/backend test suites as described.All three documents gained the standard frontmatter block with
last_verified; none has a bilingual pair (translation_status: source-only).Verification
mcp-tools.ts,packages/mcp/src/index.tspackages/runtime/src/skills-context.tsgit log -S MAKA_WEB_SEARCH_ENABLED/ repo-wide greppackages/*,apps/*npm run format:check/npm run check:asf-headersAI use
Prepared with ZCode (GLM-5.3-Flash): read the three documents, traced each checkable claim to code, and drafted the corrections. The commit carries the
Generated-bytrailer.Checklist
Refs #3522in the commit messagelast_verifiedset to the audit date (2026-09-04)