fix(eval): decode file URLs before launching test wrappers - #4769
Open
sunrioa wants to merge 1 commit into
Open
Conversation
Generated-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fileURLToPath()before passing them to child-process APIsThe Eval harness previously passed
URL.pathnamedirectly tospawn()andexecFile(). Because that value remains percent-encoded, a checkout path containing spaces was passed to Node with%20instead of the native filesystem path, preventing the wrapper or shim from launching.This change performs the platform-correct conversion at each affected child-process boundary. Production Runtime behavior is unchanged.
Fixes #4757
Verification
npm run buildnpm run lintnpm run format:checknpm run typechecknpm run check:asf-headersnpx knip --workspace apps/desktopnpx knip --workspace packages/ui@maka/evalJavaScript and Python test suites@maka/runtimetest suitenpm run check:release— 194/194 passedThe repository-wide test command was also exercised. Unrelated Runtime Host process-exit/election timing tests remained intermittent; the same class of failure was reproduced on clean
main, while isolated reruns passed.AI use
Select exactly one:
Tool(s) and scope: OpenAI Codex assisted with source inspection, implementation, and local verification. The resulting changes and this description were reviewed by me.
Checklist
Does this PR entail a change in behavior?