feat(desktop): expose bot onboarding retry health - #4746
Open
testikun wants to merge 3 commits into
Open
Conversation
added 3 commits
September 4, 2026 16:59
Generated-by: OpenAI Codex
Generated-by: OpenAI Codex
Generated-by: OpenAI Codex
testikun
force-pushed
the
codex/issue-4745-bot-onboarding-health
branch
from
September 4, 2026 09:04
6a91099 to
3a37a66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4745
Verification
npm run lint.npm run format:check.npx knip --workspace apps/desktop.npm run check:asf-headers.git diff --check.Visual evidence
Built and launched current head
3a37a66f3in a visible local Electron App. The real QR onboarding modal kept the QR available while showing only the bounded retry category, consecutive count, and retry delay. This is a direct App capture, not a mockup or generated image.The Electron test also asserts that fixture provider details do not appear in the renderer.
Review focus
The existing poll loop remains the only retry authority.
retryHealthcontains only a finite category, consecutive count, and retry timing; raw provider errors and credentials remain main-process-only.AI use
Select exactly one:
Tool(s) and scope: OpenAI Codex implemented the bounded Core/Desktop contract, main-process projection, localized UI state, deterministic lifecycle/redaction coverage, and E2E visual fixture. The human contributor remains responsible for review and submission.
Checklist
Does this PR entail a change in behavior?