fix(runtime-host): preserve legacy handoff operator - #4696
Merged
Conversation
Refs #4657 Generated-by: OpenAI Codex
12 tasks
jackwener
approved these changes
Sep 4, 2026
jackwener
left a comment
Member
There was a problem hiding this comment.
Approved at exact head 6fd0b843514e07ac5a27cb26ae5e6fbd883051a3 at the explicit direction of M4n5ter. No technical review was performed as part of this action; M4n5ter requested the approval and accepts responsibility for subsequent handling.
Review notice: This approval was submitted by an automated review agent operated by jackwener and is published at the direction of M4n5ter, who requested this action and is the human accountable for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
English
Summary
Preserve the only operator artifact guaranteed by a released schema-1 Local Runtime Host handoff when Desktop adopts an already-active managed authority. The recovered schema-2 receipt now points to the existing POSIX
operator, while schema-2 setup recovery continues to use the portable Nodeoperator.mjs.This keeps adoption read-only with respect to the managed deployment: recovery does not replay setup, change the exact package, or mutate lifecycle ownership.
Refs #4657
Root cause
The operator-command migration converted a released handoff to schema 2 before choosing its operator representation. That erased the fact that the handoff came from a release which only guaranteed
<deploymentRoot>/operator, allowing recovery to persist a receipt for anoperator.mjsthat had never been converged.Verification
git diff --checkAI use
Tool(s) and scope: OpenAI Codex adjudicated the review finding, implemented the recovery fix, and ran the targeted verification under maintainer direction.
Checklist
Does this PR entail a change in behavior?
中文
摘要
Desktop 在接管已经 active 的 managed authority 时,为已发布的 schema-1 Local Runtime Host handoff 保留该版本唯一保证存在的 operator artifact。恢复后的 schema-2 receipt 现在指向既有 POSIX
operator;schema-2 setup recovery 仍使用 portable Nodeoperator.mjs。接管过程不会修改 managed deployment:恢复时不重放 setup、不切换 exact package,也不改变 lifecycle ownership。
关联 #4657
根因
operator-command 迁移在选择 operator representation 之前先把已发布 handoff 转成了 schema 2,丢失了“该 handoff 所属版本只保证
<deploymentRoot>/operator”这一事实,因此可能持久化一个从未 converge 的operator.mjsreceipt。验证
git diff --checkAI 使用
工具与范围:OpenAI Codex 在维护者指导下裁决 review finding、实现恢复修复并完成定向验证。
检查清单
该 PR 是否改变行为?