fix(release): make unsigned Windows artifacts reproducible - #4690
Draft
Astro-Han wants to merge 6 commits into
Draft
fix(release): make unsigned Windows artifacts reproducible#4690Astro-Han wants to merge 6 commits into
Astro-Han wants to merge 6 commits into
Conversation
Exclude node-gyp projects and link scratch files from the existing global file set while preserving the native addons and ConPTY runtime helpers. This avoids creating a platform-only catch-all matcher that would reintroduce tests and renderer side-files. Exercise electron-builder normalization and dependency collection against representative runtime and build-output fixtures. Generated-by: Codex
Apply /Brepro and /DEBUG:NONE through the existing Windows command runner. /Brepro derives PE timestamps from content; /DEBUG:NONE removes unshipped PDB identity and paths after node-gyp adds /DEBUG. Two clean builds remained byte-identical after removing /INCREMENTAL:NO. Removing /DEBUG:NONE reintroduced four unpacked-payload differences, so the two remaining flags are the minimal set. Generated-by: Codex
The two clean Windows builds have identical compressed ZIP entry data; all remaining ZIP differences are DOS and NTFS modification times. Disable modification and access times at the existing 7-Zip invocation. This requires a one-line app-builder-lib patch because there is no archive flag passthrough. Test real ZIP bytes with different source timestamps and verify the extracted payload. Generated-by: Codex
The only differing NSIS header fields are the build-time FILETIMEs of app-64.7z and the uninstaller. SetDateSave off removes those fields at compilation without changing the embedded bytes. A real NSIS fixture verifies identical output after changing input timestamps; the full Windows release remains the acceptance test. Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make independently built unsigned Windows x64 payloads byte-identical while keeping
latest.yml.releaseDateas real publication metadata./Brepro /DEBUG:NONElinker flagsRefs #3276 and #3414. This does not add signing credentials or claim trusted-hardware release validation.
Verification
npm run buildnpm run check:release— 194 tests passednpm run test:windows-archives— 2 tests passednpm run formatnpm run lintactionlint .github/workflows/release-windows-check.yml/INCREMENTAL:NOremoved. The comparison job reports onlylatest.ymland the non-distributedbuilder-debug.yml./DEBUG:NONEreintroduced four unpacked-payload differences, so/Brepro /DEBUG:NONEis the minimal linker set.AI use
Select exactly one:
Tool(s) and scope: Codex diagnosed the byte differences, implemented the packaging changes and regression tests, and ran the validation and ablation experiments. Every affected commit retains a
Generated-by: Codextrailer.Checklist
Does this PR entail a change in behavior?