feat(peer): recover live routes in one connection attempt - #4580
Merged
M4n5ter merged 23 commits intoSep 3, 2026
Merged
Conversation
M4n5ter
force-pushed
the
feat/peer-live-route-recovery
branch
from
September 2, 2026 17:29
3f0185d to
539baaf
Compare
M4n5ter
force-pushed
the
feat/peer-live-route-recovery
branch
from
September 2, 2026 18:16
539baaf to
9ef4290
Compare
M4n5ter
force-pushed
the
feat/peer-live-route-recovery
branch
from
September 2, 2026 18:47
9ef4290 to
658ed0e
Compare
M4n5ter
force-pushed
the
feat/peer-live-route-recovery
branch
from
September 2, 2026 19:35
658ed0e to
4e89e78
Compare
M4n5ter
force-pushed
the
feat/peer-live-route-recovery
branch
from
September 2, 2026 20:01
4e89e78 to
ed39a7b
Compare
M4n5ter
force-pushed
the
feat/peer-live-route-recovery
branch
2 times, most recently
from
September 2, 2026 21:14
f11bb7e to
04de5f7
Compare
M4n5ter
force-pushed
the
feat/peer-live-route-recovery
branch
3 times, most recently
from
September 2, 2026 22:47
8248280 to
1640d45
Compare
Generated-by: Codex (gpt-5.6-sol)
Generated-by: Codex (gpt-5.6-sol)
Generated-by: Codex (gpt-5.6-sol)
Generated-by: Codex (gpt-5.6-sol)
Generated-by: Codex (gpt-5.6-sol)
Generated-by: Codex (gpt-5.6-sol)
Generated-by: Codex (gpt-5.6-sol)
Generated-by: Codex (gpt-5.6-sol)
Generated-by: Codex (gpt-5.6-sol)
Generated-by: Codex (gpt-5.6-sol)
Generated-by: Codex (gpt-5.6-sol)
Generated-by: Codex (gpt-5.6-sol)
Generated-by: Codex (gpt-5.6-sol)
Generated-by: Codex (gpt-5.6-sol)
Generated-by: Codex (gpt-5.6-sol)
Generated-by: Codex (gpt-5.6-sol)
Generated-by: Codex (gpt-5.6-sol)
Generated-by: Codex (gpt-5.6-sol)
Keep persisted Direct targets in the reconnect lifecycle when the first route attempt fails transiently, so later route evidence can revive them without user intervention. Preserve cancellation and permanent-failure boundaries. Generated-by: Codex (gpt-5.6-sol)
Keep deterministic Direct profile failures out of the retry loop and close the startup callback race that could reactivate a terminal lifecycle. Generated-by: Codex (gpt-5.6-sol)
Record the confirmed correctness fixes and accepted publisher-boundary simplification for the #4554 review loop. Generated-by: Codex (gpt-5.6-sol)
M4n5ter
force-pushed
the
feat/peer-live-route-recovery
branch
from
September 2, 2026 23:56
74bb1b3 to
b21fdf4
Compare
Classify an absent peer endpoint client at the same permanent Direct capability boundary as an unavailable or incompatible native addon. Generated-by: Codex (gpt-5.6-sol)
Generated-by: Codex (gpt-5.6-sol)
jackwener
approved these changes
Sep 3, 2026
jackwener
left a comment
Member
There was a problem hiding this comment.
Approved at exact head cdc82727f889e356802dc992cef5d9d73fc89a82 at the explicit direction of M4n5ter. No technical review was performed as part of this action; M4n5ter requested the approval and accepts responsibility for subsequent handling.
Review notice: This approval was submitted by an automated review agent operated by WAWQAQ and is published at the direction of M4n5ter, who requested this action and is the human accountable for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4554
Verification
Verified on the complete stacked head after rebasing from
mainateacfb46aa7ec93273bf468335f4270bba62d35a5:npm run typechecknpm run lintnpm run format:checknpm run rebuildnpm run test:dist- all workspace tests passednpm run check:renderer-architecture- 71 passednpm run check:release- 192 passedgit diff --checkcargo fmt --manifest-path native/runtime-host-peer/Cargo.toml -- --checkcargo clippy --locked --all-targets --manifest-path native/runtime-host-peer/Cargo.toml -- -D warningscargo test --locked --manifest-path native/runtime-host-peer/Cargo.toml- 28 passedimmutable installed-CLI tarball smoke
focused native client and Peer Mesh recovery suites - 27 passed
Review focus
Candidate changes are evidence for one immutable
(expected PeerId, deadline)attempt, not permission to restart work or switch identities. TypeScript supplies authenticated candidate snapshots; the native engine remains the sole dial and race authority.AI use
Tool(s) and scope: Codex implemented and verified the change under maintainer direction.
Checklist
Does this PR entail a change in behavior?