SWEEP: Removal of ICharSequence from most places, #1337 - #1387
Open
paulirwin wants to merge 10 commits into
Open
SWEEP: Removal of ICharSequence from most places, #1337#1387paulirwin wants to merge 10 commits into
paulirwin wants to merge 10 commits into
Conversation
paulirwin
added
the
notes:breaking-change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removal of ICharSequence from most places.
Fixes #1337
Description
ICharSequence is not necessary in the era of
ReadOnlySpan<char>. This sweep removes most references to it, leaving only those for IAppendable support (falling back to a more-expensive ToString operation, to be removed in #1338) and in the query node types (that have custom implementations that should be done separately. Where possible, it was replaced with ReadOnlySpan. Some tests had to be adapted with AsSpan/Slice to mimic the prior behavior.This is a breaking change because of the removal of overloads that can affect non-modern-.NET/C#14 users.