[main] Revamp the Extending, Plugins, Architecture, and Programmatic configuration pages - #4230
Open
vpelikh wants to merge 5 commits into
Open
[main] Revamp the Extending, Plugins, Architecture, and Programmatic configuration pages#4230vpelikh wants to merge 5 commits into
vpelikh wants to merge 5 commits into
Conversation
…configuration` pages (apache#2696) This work ports 466ac59 to `main`.
…nal annotations section - Update XmlConfigurationFactory and JsonConfigurationFactory from @order to @ordered - Update OrderComparator to support @ordered via AnnotationUtil - Update example files and documentation to use @ordered - Add conditional annotations section to plugins.adoc - Enhance @PluginAliases documentation in plugins.adoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports the documentation updates from PR #2696 to the current
mainbranch.The original PR #2716 was inactive for 2 years. I picked it up, cherry-picked its commits, and addressed all outstanding review comments.
Changes (5 commits)
1. Revamp pages (Volkan Yazıcı)
architecture.adoc,extending.adoc,plugins.adoc,customconfig.adocwith updated contentdependencyinjection.adocwith restructured sections (Overview, Injection Points, Names/Qualifiers, Scopes, etc.)articles.adoc,thanks.adoc,Log4jClasses.jpg2. Update plugin manual for 3.x plugin API (Matt Sicker)
plugins.adocto use@Plugin+@Configurable+@Namespacepattern instead of@Plugin(category=...)log4j-coretolog4j-pluginsRequiredClass.javaJavadoc3. Update plugins, extending, DI docs (Matt Sicker)
appenders.adoc,filters.adoc,lookups.adocplugin annotation referencesconfiguration.adocwith extension point documentationdependencyinjection.adoc,extending.adoc,layouts.adoc4. Fix typo (Matt Sicker)
denots the the→denotesinpattern-layout.adoc5. Address review comments (Vasily Pelikh)
XmlConfigurationFactory(order 5) andJsonConfigurationFactory(order 6) from@Orderto@OrderedOrderComparatornow supports both@Order(legacy) and@Ordered(new) viaAnnotationUtil.getOrder()ExampleConfigurationFactory.javafrom@Plugin(category=...)+@Order→@Plugin+@Namespace+@Orderedplugins.adoc(@ConditionalOnMissingBinding,@ConditionalOnPresentBindings)@PluginAliasesdocumentation inplugins.adocwith examplesReview status
All items from the review comment have been addressed.