OAK-12249: lazy ES index provisioning — skip creation for empty reindex - #2955
Closed
bhabegger wants to merge 2 commits into
Closed
OAK-12249: lazy ES index provisioning — skip creation for empty reindex#2955bhabegger wants to merge 2 commits into
bhabegger wants to merge 2 commits into
Conversation
bhabegger
force-pushed
the
OAK-12249-lazy-provisioning
branch
from
June 15, 2026 06:15
d61927f to
77817e0
Compare
bhabegger
force-pushed
the
OAK-12249-lazy-provisioning
branch
2 times, most recently
from
June 24, 2026 06:17
4c36816 to
2fdbd8e
Compare
bhabegger
marked this pull request as ready for review
June 24, 2026 06:22
When FT_OAK-12249 and FT_OAK-12248 are both enabled, ElasticIndexWriter defers provisionIndex() from the constructor to the first updateDocument() or deleteDocuments() call. A reindex that produces zero documents never creates an Elasticsearch index or alias, eliminating the empty-index problem described in OAK-12249. Deployment order is enforced at runtime: isLazyProvisioningActive() returns true only when both toggles are on. Enabling FT_OAK-12249 alone logs a WARN and falls back to eager provisioning, preventing 404 errors on query paths that lack graceful 404 handling. ensureProvisioned() handles the incremental-write-after-empty-reindex case: if an alias does not exist when the first document arrives, it creates a new backing index with a fresh seed and points the alias at it. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Rebased OAK-12249-lazy-provisioning onto trunk (was 77 commits behind); OAK-12248 has since merged. The rebase surfaced two issues: - FulltextIndexWriter.deleteDocuments(path) was split into deleteDocumentTree(path)/deleteDocument(path) by OAK-12244 after this branch was cut. LazyElasticIndexWriter now implements both, delegating to the real ElasticIndexWriter. - OSGi baseline check requires explicit @Version bumps for the new/changed public API surface introduced by the OAK-12249 commit: elastic (2.5.0, minor), elastic.index (3.0.0, major — ElasticIndexWriterFactory.newInstance() return type changed), and elastic.query/elastic.util (2.4.1 — declaring an explicit version at all registers as a micro change against the previously-undeclared baseline). Verified against a clean trunk checkout that neither issue exists upstream; both are specific to this branch's diff. `mvn -pl oak-search-elastic install` (compile + baseline) and the full test suite (514 tests) pass. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
bhabegger
force-pushed
the
OAK-12249-lazy-provisioning
branch
from
August 17, 2026 11:23
2fdbd8e to
d181ebe
Compare
Contributor
Author
|
Replaced by #3085 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3085 instead
Summary
provisionIndex()from theElasticIndexWriterconstructor to the firstupdateDocument(),deleteDocumentTree(), ordeleteDocument()call when bothFT_OAK-12249andFT_OAK-12248are enabledensureProvisioned()handles the incremental-write-after-empty-reindex case: if an alias does not exist when the first document arrives, it creates a new backing index with a fresh seed and points the alias at itDependency on OAK-12248
OAK-12248 (#2950, graceful 404 handling) has merged to trunk. This branch is rebased on top of it — the diff now shows only the OAK-12249 commits.
The runtime dependency remains:
isLazyProvisioningActive()returnstrueonly when bothFT_OAK-12249andFT_OAK-12248are enabled. EnablingFT_OAK-12249alone falls back to eager provisioning and logs aWARN.Tests
Three new unit tests in
ElasticIndexWriterTest:lazyProvisioning_requiresGraceful404Toggle— asserts lazy provisioning is inactive when OAK-12248 toggle is offemptyReindex_doesNotCreateEsIndex— verifies no ES index is created during construction when no documents are writtennonEmptyReindex_provisionsOnFirstDocument— verifiesprovisionIndex()is called on the firstupdateDocument()and not beforeAll 11 tests in
ElasticIndexWriterTestpass; fulloak-search-elasticsuite (514 tests) passes.Jira
https://issues.apache.org/jira/browse/OAK-12249