OAK-12162 : removed guava's cachestats and did the final cleanup

[rishabhdaim]

No description provided.

[rishabhdaim]

@reschke, this was already approved and merged, but had to be reverted due to downstream build failures.

[sonarqubecloud]

Quality Gate failed

Failed conditions
77.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

[github-actions]

Commit-Check ✔️

[rishabhdaim]

🤖 AI-generated review — automated code review via GitHub Copilot CLI (change-reviewer). 10 lenses were dispatched (correctness, tests, consistency, compatibility, design, concurrency, spec-compliance, history, reversibility, performance); findings below are the subset that survived independent confidence verification against the current diff. Treat as input for human review, not a final verdict.

Findings outside this diff:

oak-core-spi/src/main/java/org/apache/jackrabbit/oak/cache/api/CacheStatsSnapshot.java (~line 124) — 🟠 P2 · 🧪 Tests

🔍 Issue: The new plus() method uses Math.addExact (throws ArithmeticException on overflow) replacing Guava's silently-wrapping +, but has zero test coverage even though it's used by WriterCacheManager.accumulateRecordCacheStats to accumulate long-lived JMX cache stats.

🛠️ Fix: Add a CacheStatsSnapshotTest case for plus(), including an overflow boundary case asserting the new ArithmeticException.

oak-core-spi/src/main/java/org/apache/jackrabbit/oak/cache/CacheStats.java (~line 1) — 🟠 P2 · 🔗 Consistency

🔍 Issue: PLAN.md/TASKS.md document deprecating CacheStats (Guava-constructor) and keeping CacheStatsAdapter as canonical, but this PR does the opposite — it deletes CacheStatsAdapter and keeps CacheStats as the surviving, non-deprecated class with no @Deprecated annotation added.

🛠️ Fix: Update PLAN.md/TASKS.md to reflect the chosen direction, or follow the documented plan instead.

oak-core-spi/src/test/java/org/apache/jackrabbit/oak/cache/impl/CacheBuilderTest.java (~line 236) — 🟡 P3 · 🔗 Consistency

🔍 Issue: The javadoc ("CacheStatsAdapter exposes stats...") and test method name oakCacheStatsAdapterBridgesOakStats() still reference the deleted CacheStatsAdapter class, even though the method body now constructs CacheStats.

🛠️ Fix: Update the javadoc and rename the test method to reference CacheStats.

oak-lucene/pom.xml (~line 132) — 🔴 P1 · 🔄 Compatibility

🔍 Issue: Embed-Dependency still inlines the deleted CacheStatsAdapter.class from oak-core-spi, and the renamed replacement cache/api/CacheStats.class is missing from the list entirely (the existing CacheStats.class entry is a different, unrelated package).

💥 Impact: The bnd inline path list references a class that no longer exists in the embedded jar, risking a build/packaging failure or a silently incomplete bundle that reintroduces the classloader-split VerifyError this entry was added to prevent.

🛠️ Fix: Remove org/apache/jackrabbit/oak/cache/api/CacheStatsAdapter.class and add org/apache/jackrabbit/oak/cache/api/CacheStats.class to the inline list, then re-verify IndexVersionSelectionIT.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.7% Coverage on New Code
0.7% Duplication on New Code

See analysis details on SonarQube Cloud