IGNITE-28462 Upgrade remaining Maven plugins by animovscw · Pull Request #12982 · apache/ignite

animovscw · 2026-04-06T08:03:50Z

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

There is a single JIRA ticket related to the pull request.
The web-link to the pull request is attached to the JIRA ticket.
The JIRA ticket has the Patch Available state.
The pull request body describes changes that have been made.
The description explains WHAT and WHY was made instead of HOW.
The pull request title is treated as the final commit message.
The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
A reviewer has been mentioned through the JIRA comments
(see the Maintainers list)
The pull request has been checked by the Teamcity Bot and
the green visa attached to the JIRA ticket (see tab PR Check at TC.Bot - Instance 1 or TC.Bot - Instance 2)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

zstan · 2026-04-28T06:28:33Z


-                                if (file.isFile() && fileName.toLowerCase().endsWith(".class"))
+                                if (file.isFile() && fileName.toLowerCase().endsWith(".class")
+                                    && !fileName.equals("package-info.class"))


can you append a comment, why we need such a change plz ?

Plugin update revealed that there was a defect in BinaryContext .
After the version was upgraded package-info.class became physically present in the package directory on the disk. The method picked it up as a regular class and added it to the list for registration as a binary type.
Logs: https://ci2.ignite.apache.org/buildConfiguration/IgniteTests24Java8_BinaryObjects/9015329?buildTab=overview

case-sensitive comparison - need to be fixed

Fixed: 3453f4b

zstan · 2026-05-07T05:01:01Z

    private String readStream(InputStream inputStream) throws IOException {
        ByteArrayOutputStream baos = new ByteArrayOutputStream();
-        IOUtils.copy(inputStream, baos);
+        byte[] buf = new byte[4096];


if you decide to remove import org.apache.commons.io.* dependency it need to be done through whole module, i.e. such method need to e moved into some utility class, othervize you need to revert such a change

The decision of this change is not about removing commons-io. JavaVersionCommand.java runs inside a forked JVM. The forked process classpath does not include test-scoped dependencies, so commons-io is not available here.

zstan · 2026-05-07T05:03:35Z

            <scope>test</scope>
        </dependency>
+
+        <dependency>


i found that all compile properly well without this change, wdyt ?

You are right. commons-io is no longer used in compress tests after replacing FileUtils.sizeOfDirectory.

zstan · 2026-05-07T05:05:05Z

                File nodeFolder = ((IgniteEx)node).context().pdsFolderResolver().fileTree().nodeStorage();

                if (nodeFolder != null)
-                    pers += FileUtils.sizeOfDirectory(nodeFolder);


the same as below: if you want to remove this dependency, such method need to be moved into some test utility class, othrvize revert this change or explain why you need it ?

Modified: 947be11

zstan · 2026-05-12T06:53:40Z

     * @throws IOException If something goes wrong.
     */
    private String readStream(InputStream inputStream) throws IOException {
+        // commons-io (IOUtils) is intentionally not used here.


probably need to move into GridTestIoUtils ?

You're right. Done: 158bb0c

Previous keystore used 1024-bit DSA key expired in 2007. maven-jarsigner-plugin 3.1.0 enforces strict validation and rejects signing with weak/expired certificates. Replaced with RSA 2048-bit key valid for 10 years.

…block

nao-it · 2026-05-14T08:54:55Z

                    <groupId>net.alchim31.maven</groupId>
                    <artifactId>scala-maven-plugin</artifactId>
-                    <version>3.3.2</version>
+                    <version>4.9.9</version>


In the core code of Apache Ignite, Scala is not used anywhere else. I suggest removing it and then adding necessary plugins to ignite-extensions if needed later on.

Removed: 514b67f

zstan · 2026-05-14T12:07:49Z


-                                    if (!clsName.contains("/") && !clsName.contains("\\"))
+                                    if (!clsName.contains("/") && !clsName.contains("\\")
+                                        && !clsName.equals("package-info"))


the same as above

Fixed: 3453f4b

…lter in BinaryContext

sonarqubecloud · 2026-05-15T14:18:36Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud · 2026-05-18T07:15:25Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

animovscw changed the title ~~IGNITE-28462 Upgrade remaining Maven plugins~~ IGNITE-28462: Upgrade remaining Maven plugins Apr 6, 2026

animovscw force-pushed the ignite-28462 branch 3 times, most recently from 812a406 to 724521a Compare April 16, 2026 07:36

zstan reviewed Apr 16, 2026

View reviewed changes

Comment thread modules/compress/pom.xml Outdated

animovscw force-pushed the ignite-28462 branch from 9bbf92b to 761b8e3 Compare April 17, 2026 08:33

animovscw requested a review from ptupitsyn as a code owner April 20, 2026 10:36

animovscw force-pushed the ignite-28462 branch 2 times, most recently from c9de64f to 8217e35 Compare April 20, 2026 18:13

zstan reviewed Apr 28, 2026

View reviewed changes

zstan requested a review from vveider April 28, 2026 06:30

animovscw force-pushed the ignite-28462 branch 2 times, most recently from 8e2be78 to c22462b Compare May 5, 2026 03:19

zstan reviewed May 7, 2026

View reviewed changes

Comment thread modules/extdata/uri/config/signeddeploy/keystore

zstan reviewed May 7, 2026

View reviewed changes

animovscw force-pushed the ignite-28462 branch from 1dd9330 to 5339430 Compare May 8, 2026 08:26

zstan reviewed May 12, 2026

View reviewed changes

animovscw added 11 commits May 14, 2026 10:07

IGNITE-28462 Upgrade central Maven plugin versions

27271b9

IGNITE-28462 Upgrade Maven plugin versions in auxiliary modules

64b1274

IGNITE-28462: Upgrade module-specific Maven plugins

a0e67a7

IGNITE-28462: Complete remaining Maven plugin upgrades

8340dc7

IGNITE-28462: Complete remaining Maven plugin upgrades

7d05ef4

IGNITE-28462: Fix javadoc warnings

e2745a3

IGNITE-28462: Fix compatibility test runtime dependency on commons-io

3ad83fd

IGNITE-28462: Fix test failures caused by Maven plugin upgrades

6ec70f9

IGNITE-28462: Renew expired test keystore for URI deployment tests

6b86b01

Previous keystore used 1024-bit DSA key expired in 2007. maven-jarsigner-plugin 3.1.0 enforces strict validation and rejects signing with weak/expired certificates. Replaced with RSA 2048-bit key valid for 10 years.

IGNITE-28462: Replace hardcoded plugin versions with properties

ca8fb34

IGNITE-28462: Remove redundant dependency from the module

b3691f8

animovscw added 4 commits May 14, 2026 10:07

IGNITE-28462: Move sizeOfDirectory to GridTestUtils to make it reusable

ccc92eb

IGNITE-28462: Add an inline comment to readStream

1d2626a

IGNITE-28462: Move readStream to GridTestIoUtils

4c7922d

IGNITE-28462: Remove accidentally restored build-helper-maven-plugin …

da71f3e

…block

animovscw force-pushed the ignite-28462 branch from ae18b47 to da71f3e Compare May 14, 2026 03:07

nao-it reviewed May 14, 2026

View reviewed changes

zstan reviewed May 14, 2026

View reviewed changes

animovscw added 2 commits May 14, 2026 20:21

IGNITE-28462: Remove scala-maven-plugin and scala.library.version

514b67f

IGNITE-28462: Fix case-sensitive comparison for package-info.class fi…

3453f4b

…lter in BinaryContext

IGNITE-28462: Fix NoClassDefFoundError for commons-io in indexing tests

0eb7f30

animovscw changed the title ~~IGNITE-28462: Upgrade remaining Maven plugins~~ IGNITE-28462 Upgrade remaining Maven plugins May 18, 2026

Conversation

animovscw commented Apr 6, 2026

The Contribution Checklist

Notes

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

animovscw Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

animovscw May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

animovscw May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

animovscw May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented May 15, 2026

Quality Gate passed

Uh oh!

sonarqubecloud Bot commented May 18, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

animovscw Apr 28, 2026 •

edited

Loading

animovscw May 8, 2026 •

edited

Loading

animovscw May 8, 2026 •

edited

Loading

animovscw May 13, 2026 •

edited

Loading