IGNITE-27678 Same partitions on different nodes can hold different updates if writeThrough is enabled#12925
Open
zstan wants to merge 15 commits into
Open
IGNITE-27678 Same partitions on different nodes can hold different updates if writeThrough is enabled#12925zstan wants to merge 15 commits into
zstan wants to merge 15 commits into
Conversation
zstan
force-pushed
the
ignite-27678-nostruct
branch
2 times, most recently
from
c623095 to
2029771
Compare
zstan
force-pushed
the
ignite-27678-nostruct
branch
3 times, most recently
from
0bfd72d to
ff5d209
Compare
…dates if writeThrough is enabled
zstan
force-pushed
the
ignite-27678-nostruct
branch
from
ff5d209 to
d2bb726
Compare
|
There was a problem hiding this comment.
Pull request overview
This PR addresses transaction recovery for write-through caches so surviving nodes do not retain divergent partition updates after a node leaves during transaction completion.
Changes:
- Adds a DHT transaction salvage message and handling paths for write-through recovery.
- Adjusts transaction manager/future recovery behavior and store-session exception propagation.
- Adds and updates tests covering write-through recovery, idle verify consistency, and leftover salvage transaction cleanup.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/IndexingSpiQueryTxSelfTest.java |
Updates expected transaction exception behavior and waits for futures. |
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteTxCacheWriteSynchronizationModesMultithreadedTest.java |
Adds post-test assertion for empty salvage transaction tracking. |
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/dht/IgniteCacheTxRecoveryRollbackTest.java |
Extends cleanup checks to include salvage transaction state. |
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxRemoteStateImpl.java |
Makes remote tx state maps final. |
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxRemoteStateAdapter.java |
Makes active cache ID list final. |
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxManager.java |
Adds write-through-specific salvage/recovery coordination. |
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxHandler.java |
Registers handling for DHT salvage requests. |
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxAdapter.java |
Adjusts nullable annotation on finalization status implementation. |
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/store/GridCacheStoreManagerAdapter.java |
Logs and propagates runtime store-session listener failures. |
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxFinishFuture.java |
Sends salvage requests to backups during committed checks for write-through txs. |
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/GridDhtLocalPartition.java |
Improves partition-state assertion diagnostics. |
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionsExchangeFuture.java |
Suppresses unused warning for retained field. |
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxSalvageMessage.java |
Adds a new cache message for transaction salvage. |
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxRemote.java |
Simplifies master node ID collection creation. |
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxLocal.java |
Salvages local write-through txs on heuristic failure. |
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxFinishFuture.java |
Adds node-id-aware salvage handling when a finish target has left. |
modules/control-utility/src/test/java/org/apache/ignite/util/IdleVerifyCheckWithWriteThroughTest.java |
Adds idle-verify regression coverage for write-through tx recovery. |
modules/control-utility/src/test/java/org/apache/ignite/testsuites/IgniteControlUtilityTestSuite2.java |
Includes the new write-through idle-verify test in the suite. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| log.error("Unable to send message (node left topology): " + n); | ||
|
|
||
| fut.onNodeLeft(); | ||
| fut.onNodeLeft(n.id()); |
zstan
commented
May 18, 2026
|
|
||
| // Treat heuristic exception as critical. | ||
| if (X.hasCause(e, IgniteTxHeuristicCheckedException.class)) | ||
| if (X.hasCause(e, IgniteTxHeuristicCheckedException.class)) { |
Contributor
Author
There was a problem hiding this comment.
IndexingSpiQueryTxSelfTest
Possible compatibility issues. Please, check rolling upgrade casesThis PR modifies protected classes (with Order annotation). Affected files:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.