IGNITE-28664 Fix failed tests in Disk Page Compressions 4 Suite#12913
IGNITE-28664 Fix failed tests in Disk Page Compressions 4 Suite#12913zstan wants to merge 4 commits into
Conversation
zstan
force-pushed
the
testClusterSnapshotHandlers
branch
from
95a913b to
ba090a7
Compare
|
zstan
force-pushed
the
testClusterSnapshotHandlers
branch
3 times, most recently
from
0b76cb9 to
64b8918
Compare
zstan
force-pushed
the
testClusterSnapshotHandlers
branch
from
64b8918 to
27978ad
Compare
zstan
changed the title
|
|
||
| GridTestUtils.assertThrowsAnyCause(log, () -> fut.get(TIMEOUT), IgniteCheckedException.class, expMsg); | ||
| runWithLogggedThreadDump(() -> | ||
| GridTestUtils.assertThrowsAnyCause(log, () -> fut.get(TIMEOUT), IgniteCheckedException.class, expMsg)); |
There was a problem hiding this comment.
This one coming from AbstractSnapshotSelfTest which is 15sec. I see you had only 1 run for Disk Page Compressions 5 which might not be enough. The timeout is not changed so I anticipate further failures. The ticket is for Disk 4, and the test fails on Disk 5, we should either fix Disk 5 as well and add it to the ticket description or remove this change.
|
|
||
| ignite.snapshot().restoreSnapshot(SNAPSHOT_NAME, null).get(TIMEOUT); | ||
| runWithLogggedThreadDump(() -> | ||
| ignite.snapshot().restoreSnapshot(SNAPSHOT_NAME, null).get(TIMEOUT)); |
|
|
||
| grid(0).snapshot().restoreSnapshot(SNAPSHOT_NAME, Collections.singleton(DEFAULT_CACHE_NAME)).get(TIMEOUT); | ||
| runWithLogggedThreadDump(() -> | ||
| grid(0).snapshot().restoreSnapshot(SNAPSHOT_NAME, Collections.singleton(DEFAULT_CACHE_NAME)).get(TIMEOUT)); |
There was a problem hiding this comment.
This one coming from AbstractSnapshotSelfTest which is 15sec. I see you had only 1 run for Disk Page Compressions 6 which might not be enough. The timeout is not changed so I anticipate further failures. The ticket is for Disk 4, and the test fails on Disk 6, we should either fix Disk 6 as well and add it to the ticket description or remove this change.
There was a problem hiding this comment.
Timeouts unchanged. Test is failing on teamcity
|
now we have: |
| } | ||
|
|
||
| /** Print thread dump if {@code IgniteFutureTimeoutException} is raised. */ | ||
| protected void runWithLogggedThreadDump(Runnable action) { |
| private final List<SnapshotHandler<?>> handlers = new ArrayList<>(); | ||
|
|
||
| /** Timeout in milliseconds to await for snapshot operation being completed. */ | ||
| protected static final long TIMEOUT = 60_000; |
There was a problem hiding this comment.
Could you clarify the scope of this PR? The ticket description mentions covering only Disk 4 tests, but this PR modifies IgniteClusterSnapshotHandlerTest, which belongs to the Disk 5 suite.
- If we are including Disk 5: Please update the ticket description to avoid confusion. Also, can we update the timeouts for
IgniteSnapshotMXBeanTestwhile we are at it? - If Disk 5 is out of scope: I suggest reverting the changes to
IgniteClusterSnapshotHandlerTestto keep this PR focused.
| */ | ||
| public class IgniteClusterSnapshotCheckWithIndexesTest extends AbstractSnapshotSelfTest { | ||
| /** Timeout in milliseconds to await for snapshot operation being completed. */ | ||
| protected static final long TIMEOUT = 60_000; |
There was a problem hiding this comment.
Same question as for IgniteClusterSnapshotHandlerTest.
The ticket description mentions covering only Disk 4 tests, but this PR modifies IgniteClusterSnapshotCheckWithIndexingTest as well as IgniteClusterSnapshotRestoreWithIndexingTest, which belongs to the Disk 6 suite.
- If we are including Disk 6: Please update the ticket description to avoid confusion. Also, can we update the timeouts for
IgniteClusterSnapshotMetricsTestwhile we are at it? And I seeIgniteClusterSnapshotRestoreWithIndexingTesttimeouts unchanged. Was it on purpuse? - If Disk 6 is out of scope: I suggest reverting the changes to keep this PR focused.
|
|
||
| grid(0).snapshot().restoreSnapshot(SNAPSHOT_NAME, Collections.singleton(DEFAULT_CACHE_NAME)).get(TIMEOUT); | ||
| runWithLogggedThreadDump(() -> | ||
| grid(0).snapshot().restoreSnapshot(SNAPSHOT_NAME, Collections.singleton(DEFAULT_CACHE_NAME)).get(TIMEOUT)); |
There was a problem hiding this comment.
Timeouts unchanged. Test is failing on teamcity
|
2 participants
No description provided.