IGNITE-27746 MDC. Implement parallel ping of DC2's nodes with the connection recovery.#12729
Merged
sergey-chugunov-1985 merged 46 commits intoMay 18, 2026
Conversation
…warness-for-connection-recovery-mechanism
…-connection-recovery-mechanism # Conflicts: # modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpi.java # modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryPendingMessageDeliveryTest.java # modules/core/src/test/java/org/apache/ignite/testsuites/IgniteSpiDiscoverySelfTestSuite.java
…-connection-recovery-mechanism
…-connection-recovery-mechanism-improve
…ecovery-mechanism-improve' into IGNITE-26986-Multi-datacenter-awarness-for-connection-recovery-mechanism
…-connection-recovery-mechanism
Vladsz83
changed the title
…-connection-recovery-mechanism
…-connection-recovery-mechanism
|
|
||
| if (allRemoteDCsTraversed(sndState, failedNodes, next)) { | ||
| if (log.isInfoEnabled()) { | ||
| log.info("During the connection recovery, all the remote DCs have been traversed. " + |
Contributor
There was a problem hiding this comment.
Please use this phrase instead: "Connection recovery finished: all remote DCs traversed, none available. Current node will skip failed DCs. Ring connection recovery time remaining:"
Contributor
Author
There was a problem hiding this comment.
Fixed partly. Let's rely on the phrase "During connection recovery" widely used before with the parallel DCs ping.
Co-authored-by: Sergey Chugunov <sergey.chugunov@gmail.com>
…ss-for-connection-recovery-mechanism' into IGNITE-26986-Multi-datacenter-awarness-for-connection-recovery-mechanism
| return false; | ||
|
|
||
| // Remote DC statuses: alive or not, Dc id -> true/false. | ||
| Collection<String> rmtDcIds = connRecoverState.rmtDcPingRes.keySet().stream().map(ClusterNode::dataCenterId) |
Contributor
There was a problem hiding this comment.
Please introduce additional method to ConnectionRecoveryState instead of exposing rmtDcPingRes and performing opeations on it. Also I think comment above this line is incorrect.
Contributor
Author
There was a problem hiding this comment.
It is not exposed, it is private. But is included into an internall class. And is used only by a holding class. I don't thing we need any methods to access internal-only classes. Also, ConnectionRecoveryState becomes shorter without extra methods while ServerImpl is already quite large.
sergey-chugunov-1985
approved these changes
May 18, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.