feat(encryption) [13/N] Write encrypted manifest files#2821
Open
xanderbailey wants to merge 5 commits into
Open
feat(encryption) [13/N] Write encrypted manifest files#2821xanderbailey wants to merge 5 commits into
xanderbailey wants to merge 5 commits into
Conversation
xanderbailey
changed the title
Contributor
Author
|
@blackmwk I think this is ready for a review when you have the time! Thanks! |
blackmwk
reviewed
Jul 22, 2026
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn write_encrypted_manifest_roundtrips() { |
Contributor
There was a problem hiding this comment.
I'm hesitating to add test for such low level apis here. I think you add a test in one of the snapshot producing operator like FastAppend to test
…/write_encrypted_manifest_files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Today it is possible to read encrypted manifest files but not write them.
#2568 adds the foundations of what's needed to be able to do these writes but it wasn't wired into the actual write path.
Are these changes tested?
Yes - added round-trip write path test.