test(transaction): Add round-trip tests for Properties & Location#2392
Open
Kurtiscwright wants to merge 2 commits intoapache:mainfrom
Open
test(transaction): Add round-trip tests for Properties & Location#2392Kurtiscwright wants to merge 2 commits intoapache:mainfrom
Kurtiscwright wants to merge 2 commits intoapache:mainfrom
Conversation
…teLocation Adds three end-to-end tests that exercise Transaction::commit against an in-process MemoryCatalog, covering UpdatePropertiesAction, UpdateLocationAction, and a chained transaction that combines both. Each test asserts post-commit metadata state on both the returned Table and a fresh load_table from the catalog. Also adds a make_v2_minimal_table_in_catalog helper in transaction::tests, parallel to the existing make_v3_minimal_table_in_catalog. First PR for apache#1322 next PR will implement tests for (FastAppend beyond test_row_lineage, UpgradeFormatVersion, ReplaceSortOrder, UpdateStatistics) to follow in a separate PR once this PR is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three end-to-end tests that exercise Transaction::commit against an in-process MemoryCatalog, covering UpdatePropertiesAction, UpdateLocationAction, and a chained transaction that combines both. Each test asserts post-commit metadata state on both the returned Table and a fresh load_table from the catalog.
Also adds a make_v2_minimal_table_in_catalog helper in transaction::tests, parallel to the existing make_v3_minimal_table_in_catalog.
First PR for #1322 next PR will implement tests for (FastAppend beyond test_row_lineage, UpgradeFormatVersion, ReplaceSortOrder, UpdateStatistics) to follow in a separate PR once this PR is merged.
Which issue does this PR close?
What changes are included in this PR?
Are these changes tested?