Merge python-integration.yml into python-ci.yml #1963
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -66,3 +66,20 @@ jobs: | |
| run: make lint | ||
| - name: Tests | ||
| run: make test-coverage | ||
|
|
||
| integration-test: | ||
| runs-on: ubuntu-22.04 | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 2 | ||
|
Contributor
There was a problem hiding this comment. Any specific reason for depth 2? The default is 1.
Member
Author
There was a problem hiding this comment. This was copy and paste from the old Shall I remove it? I don't see a reason either? |
||
| - name: Install system dependencies | ||
| run: sudo apt-get update && sudo apt-get install -y libkrb5-dev # for kerberos | ||
| - name: Install | ||
| run: make install | ||
| - name: Run integration tests | ||
| run: make test-integration | ||
|
Contributor
There was a problem hiding this comment. I dont think we want to do this. L68's I think we'd want to get rid of one OR have one run unit tests and another run integration tests. Looking at both github actions.
Member
Author
There was a problem hiding this comment. Ah, nice catch. Personally, I like the idea of having them stay separate, so they can run in parallel. I pushed a change separating them while still running the full Python version matrix for both unit and integration tests with coverage. What do you think? |
||
| - name: Show debug logs | ||
| if: ${{ failure() }} | ||
| run: docker compose -f dev/docker-compose.yml logs | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. This will also run the integration tests 🤣