Skip to content

Commit e9e9485

Browse files
committed
Update comment
1 parent 6f50b48 commit e9e9485

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

pyiceberg/table/upsert_util.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,9 @@ def get_rows_to_update(source_table: pa.Table, target_table: pa.Table, join_cols
7272
# When the target table is empty, there is nothing to update :)
7373
return source_table.schema.empty_table()
7474

75+
# We need to compare non_key_cols in Python as PyArrow
76+
# 1. Cannot do a join when non-join columns have complex types
77+
# 2. Cannot compare columns with complex types
7578
# See: https://github.com/apache/arrow/issues/35785
7679
MARKER_COLUMN_NAME = "__from_target"
7780
SOURCE_INDEX_COLUMN_NAME = "__source_index"

0 commit comments

Comments
 (0)