Skip to content

Commit 6f50b48

Browse files
committed
Update comment
1 parent 79f6181 commit 6f50b48

2 files changed

Lines changed: 0 additions & 3 deletions

File tree

pyiceberg/table/upsert_util.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,6 @@ def get_rows_to_update(source_table: pa.Table, target_table: pa.Table, join_cols
7272
# When the target table is empty, there is nothing to update :)
7373
return source_table.schema.empty_table()
7474

75-
# When we are not able to compare (e.g. due to unsupported types),
76-
# fall back to selecting only rows in the source table that do NOT already exist in the target.
7775
# See: https://github.com/apache/arrow/issues/35785
7876
MARKER_COLUMN_NAME = "__from_target"
7977
SOURCE_INDEX_COLUMN_NAME = "__source_index"

tests/table/test_upsert.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -520,7 +520,6 @@ def test_upsert_struct_field_fails_in_join(catalog: Catalog) -> None:
520520
NestedField(
521521
2,
522522
"nested_type",
523-
# Struct<type: string, coordinates: list<double>>
524523
StructType(
525524
NestedField(3, "sub1", StringType(), required=True),
526525
NestedField(4, "sub2", StringType(), required=True),

0 commit comments

Comments
 (0)