Draft ready

Author: ForeverAngry

pyiceberg/table/update/snapshot.py

@@ -885,11 +885,13 @@ def _commit(self) -> Tuple[Tuple[TableUpdate, ...], Tuple[TableRequirement, ...]
         if not self._ids_to_remove:
             raise ValueError("No snapshot IDs marked for expiration.")
 
-
+        # print all children snapshots of the current snapshot
+        print(f"Current snapshot ID of {self._transaction._table.current_snapshot()} which has {len(self._transaction._table.snapshots())}")
         print(f"Totals number of snapshot IDs to expire: {len(self._ids_to_remove)}")
         print(f"Total number of snapshots in the table: {len(self._transaction.table_metadata.snapshots)}")
         # Ensure current snapshots in refs are not marked for removal
         current_snapshot_ids = {ref.snapshot_id for ref in self._transaction.table_metadata.refs.values()}
+
         print(f"Current snapshot IDs in refs: {current_snapshot_ids}")
         print(f"Snapshot IDs marked for removal: {self._ids_to_remove}")
         conflicting_ids = self._ids_to_remove.intersection(current_snapshot_ids)
@@ -910,7 +912,7 @@ def _commit(self) -> Tuple[Tuple[TableUpdate, ...], Tuple[TableRequirement, ...]
             for ref_name, ref in self._transaction.table_metadata.refs.items()
             if ref.snapshot_id not in self._ids_to_remove
         )
-        
+
         self._requirements += requirements
         return self._updates, self._requirements
 

tests/table/test_expire_snapshots.py

@@ -164,17 +164,11 @@ def test_remove_snapshot(table_v2_with_extensive_snapshots: Table):
     assert table.metadata is not None, "Table metadata is None"
     assert table.metadata.current_snapshot_id is not None, "Current snapshot ID is None"
 
-    initial_snapshot_id = table.metadata.current_snapshot_id
+    snapshot_to_expire = 3051729675574599003
 
     # Ensure the table has snapshots
     assert table.metadata.snapshots is not None, "Snapshots list is None"
     assert len(table.metadata.snapshots) == 2000, f"Expected 2000 snapshots, got {len(table.metadata.snapshots)}"
-    
-    # Find an older snapshot that is not the current snapshot
-    for snapshot in table.metadata.snapshots:
-        if snapshot.snapshot_id != initial_snapshot_id and snapshot.snapshot_id not in table.metadata.refs.values():
-            snapshot_to_expire = snapshot.snapshot_id
-            break
 
     assert snapshot_to_expire is not None, "No valid snapshot found to expire"
 
@@ -187,5 +181,4 @@ def test_remove_snapshot(table_v2_with_extensive_snapshots: Table):
 
     # Use the built-in pytest capsys fixture to capture printed output
     print(f"Snapshot ID {snapshot_to_expire} expired successfully")
-    print(f"Number of snapshots after expiry: {len(table.metadata.snapshots)}")
-    print(table.metadata.snapshots)
+    print(f"Number of snapshots after expiry: {table.metadata}")