adding print statements to help with debugging

Author: ForeverAngry

pyiceberg/table/update/snapshot.py

@@ -885,25 +885,32 @@ def _commit(self) -> Tuple[Tuple[TableUpdate, ...], Tuple[TableRequirement, ...]
         if not self._ids_to_remove:
             raise ValueError("No snapshot IDs marked for expiration.")
 
+
+        print(f"Totals number of snapshot IDs to expire: {len(self._ids_to_remove)}")
+        print(f"Total number of snapshots in the table: {len(self._transaction.table_metadata.snapshots)}")
         # Ensure current snapshots in refs are not marked for removal
         current_snapshot_ids = {ref.snapshot_id for ref in self._transaction.table_metadata.refs.values()}
+        print(f"Current snapshot IDs in refs: {current_snapshot_ids}")
+        print(f"Snapshot IDs marked for removal: {self._ids_to_remove}")
         conflicting_ids = self._ids_to_remove.intersection(current_snapshot_ids)
+        print(f"Conflicting snapshot IDs: {conflicting_ids}")
+        
         if conflicting_ids:
             # Remove references to the conflicting snapshots before expiring them
             for ref_name, ref in list(self._transaction.table_metadata.refs.items()):
                 if ref.snapshot_id in conflicting_ids:
                     self._updates += (RemoveSnapshotRefUpdate(ref_name=ref_name),)
 
         # Remove the snapshots
-        updates = (RemoveSnapshotsUpdate(snapshot_ids=list(self._ids_to_remove)),)
+        self._updates = (RemoveSnapshotsUpdate(snapshot_ids=list(self._ids_to_remove)),)
 
         # Ensure refs haven't changed (snapshot ID consistency check)
         requirements = tuple(
             AssertRefSnapshotId(snapshot_id=ref.snapshot_id, ref=ref_name)
             for ref_name, ref in self._transaction.table_metadata.refs.items()
             if ref.snapshot_id not in self._ids_to_remove
         )
-        self._updates += updates
+        
         self._requirements += requirements
         return self._updates, self._requirements
 

tests/table/test_expire_snapshots.py

@@ -169,13 +169,8 @@ def test_remove_snapshot(table_v2_with_extensive_snapshots: Table):
     # Ensure the table has snapshots
     assert table.metadata.snapshots is not None, "Snapshots list is None"
     assert len(table.metadata.snapshots) == 2000, f"Expected 2000 snapshots, got {len(table.metadata.snapshots)}"
-
-    # Print snapshot information for debugging
-    print(f"Initial snapshot ID: {initial_snapshot_id}")
-    print(f"Number of snapshots before expiry: {len(table.metadata.snapshots)}")
-
+    
     # Find an older snapshot that is not the current snapshot
-    snapshot_to_expire = None
     for snapshot in table.metadata.snapshots:
         if snapshot.snapshot_id != initial_snapshot_id and snapshot.snapshot_id not in table.metadata.refs.values():
             snapshot_to_expire = snapshot.snapshot_id
@@ -190,5 +185,7 @@ def test_remove_snapshot(table_v2_with_extensive_snapshots: Table):
     assert snapshot_to_expire not in [snapshot.snapshot_id for snapshot in table.metadata.snapshots], \
         f"Snapshot ID {snapshot_to_expire} was not removed"
 
+    # Use the built-in pytest capsys fixture to capture printed output
     print(f"Snapshot ID {snapshot_to_expire} expired successfully")
-    print(f"Number of snapshots after expiry: {len(table.metadata.snapshots)}")
+    print(f"Number of snapshots after expiry: {len(table.metadata.snapshots)}")
+    print(table.metadata.snapshots)