WIP

Author: Fokko

pyiceberg/manifest.py

@@ -879,31 +879,30 @@ def fetch_manifest_entry(self, io: FileIO, discard_deleted: bool = True) -> list
         # but this is the easiest for now until we
         # have the write part in there as well
         def _convert_entry(entry: Any) -> ManifestEntry:
-            data_file = DataFile(
-                DataFileContent(entry.data_file.content),
-                entry.data_file.file_path,
-                FileFormat(entry.data_file.file_format),
-                Record(*(p.value() if p is not None else None for p in entry.data_file.partition)),
-                entry.data_file.record_count,
-                entry.data_file.file_size_in_bytes,
-                entry.data_file.column_sizes,
-                entry.data_file.value_counts,
-                entry.data_file.null_value_counts,
-                entry.data_file.nan_value_counts,
-                entry.data_file.lower_bounds,
-                entry.data_file.upper_bounds,
-                entry.data_file.key_metadata,
-                entry.data_file.split_offsets,
-                entry.data_file.equality_ids,
-                entry.data_file.sort_order_id,
-            )
-
+            data_file = entry.data_file
             return ManifestEntry(
                 ManifestEntryStatus(entry.status),
                 entry.snapshot_id,
                 entry.sequence_number,
                 entry.file_sequence_number,
-                data_file,
+                DataFile(
+                    DataFileContent(data_file.content),
+                    data_file.file_path,
+                    FileFormat(data_file.file_format),
+                    Record(*(p.value() if p is not None else None for p in data_file.partition)),
+                    data_file.record_count,
+                    data_file.file_size_in_bytes,
+                    data_file.column_sizes,
+                    data_file.value_counts,
+                    data_file.null_value_counts,
+                    data_file.nan_value_counts,
+                    data_file.lower_bounds,
+                    data_file.upper_bounds,
+                    data_file.key_metadata,
+                    data_file.split_offsets,
+                    data_file.equality_ids,
+                    data_file.sort_order_id,
+                ),
             )
 
         return [

tests/integration/test_partitioning_key.py

@@ -326,25 +326,26 @@
             (CAST('example' AS BINARY), 'Associated string value for binary `example`')
             """,
         ),
-        (
-            [PartitionField(source_id=13, field_id=1001, transform=IdentityTransform(), name="decimal_field")],
-            [Decimal("123.45")],
-            Record(Decimal("123.45")),
-            "decimal_field=123.45",
-            f"""CREATE TABLE {identifier} (
-                decimal_field decimal(5,2),
-                string_field string
-            )
-            USING iceberg
-            PARTITIONED BY (
-                identity(decimal_field)
-            )
-            """,
-            f"""INSERT INTO {identifier}
-            VALUES
-            (123.45, 'Associated string value for decimal 123.45')
-            """,
-        ),
+        # DISCUSSED IN https://github.com/apache/iceberg-rust/discussions/2062
+        # (
+        #     [PartitionField(source_id=13, field_id=1001, transform=IdentityTransform(), name="decimal_field")],
+        #     [Decimal("123.45")],
+        #     Record(Decimal("123.45")),
+        #     "decimal_field=123.45",
+        #     f"""CREATE TABLE {identifier} (
+        #         decimal_field decimal(5,2),
+        #         string_field string
+        #     )
+        #     USING iceberg
+        #     PARTITIONED BY (
+        #         identity(decimal_field)
+        #     )
+        #     """,
+        #     f"""INSERT INTO {identifier}
+        #     VALUES
+        #     (123.45, 'Associated string value for decimal 123.45')
+        #     """,
+        # ),
         # # Year Month Day Hour Transform
         # Month Transform
         (