Skip to content

Commit ecd7eac

Browse files
committed
Revert changes
1 parent e03f10f commit ecd7eac

6 files changed

Lines changed: 715 additions & 37 deletions

File tree

pyiceberg/table/inspect.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -559,7 +559,7 @@ def _get_files_from_manifest(
559559
if data_file_filter and data_file.content not in data_file_filter:
560560
continue
561561
column_sizes = data_file.column_sizes or {}
562-
value_counts = data_file.value_counts
562+
value_counts = data_file.value_counts or {}
563563
null_value_counts = data_file.null_value_counts or {}
564564
nan_value_counts = data_file.nan_value_counts or {}
565565
lower_bounds = data_file.lower_bounds or {}

pyproject.toml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ name = "pyiceberg"
1919
version = "0.10.0"
2020
description = "Apache Iceberg is an open table format for huge analytic datasets"
2121
authors = [{ name = "Apache Software Foundation", email = "dev@iceberg.apache.org" }]
22-
requires-python = ">=3.10.0,<=3.13.0"
22+
requires-python = ">=3.10.0,<4.0.0"
2323
readme = "README.md"
2424
license = "Apache-2.0"
2525
license-files = ["LICENSE", "NOTICE"]
@@ -98,12 +98,6 @@ pyiceberg-core = ["pyiceberg-core>=0.5.1,<0.9.0"]
9898
datafusion = ["datafusion>=51,<52"]
9999
gcp-auth = ["google-auth>=2.4.0"]
100100

101-
[[tool.uv.index]]
102-
name = "testpypi"
103-
url = "https://test.pypi.org/simple/"
104-
publish-url = "https://test.pypi.org/legacy/"
105-
explicit = true
106-
107101
[dependency-groups]
108102
dev = [
109103
"pytest==7.4.4",

tests/integration/test_hive_migration.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424

2525

2626
@pytest.mark.integration
27-
@pytest.mark.skip("Waiting on an upstream fix: https://github.com/apache/iceberg/pull/14163")
2827
def test_migrate_table(
2928
session_catalog_hive: Catalog,
3029
spark: SparkSession,

tests/integration/test_inspect_table.py

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,7 @@ def _inspect_files_asserts(df: pa.Table, spark_df: DataFrame) -> None:
129129
"record_count",
130130
"file_size_in_bytes",
131131
"split_offsets",
132-
# Fixed in https://github.com/apache/iceberg-rust/pull/1705
133-
# "equality_ids",
132+
"equality_ids",
134133
"sort_order_id",
135134
]
136135
]
@@ -143,19 +142,14 @@ def _inspect_files_asserts(df: pa.Table, spark_df: DataFrame) -> None:
143142
"record_count",
144143
"file_size_in_bytes",
145144
"split_offsets",
146-
# Fixed in https://github.com/apache/iceberg-rust/pull/1705
147-
# "equality_ids",
145+
"equality_ids",
148146
"sort_order_id",
149147
]
150148
]
151149

152150
assert_frame_equal(lhs_subset, rhs_subset, check_dtype=False, check_categorical=False)
153151

154152
for column in df.column_names:
155-
if column == "equality_ids":
156-
# Fixed in https://github.com/apache/iceberg-rust/pull/1705
157-
continue
158-
159153
if column == "partition":
160154
# Spark leaves out the partition if the table is unpartitioned
161155
continue
@@ -363,10 +357,6 @@ def check_pyiceberg_df_equals_spark_df(df: pa.Table, spark_df: DataFrame) -> Non
363357
# Arrow turns dicts into lists of tuple
364358
df_lhs = dict(df_lhs)
365359

366-
if "equality_ids" == df_column:
367-
# Fixed in https://github.com/apache/iceberg-rust/pull/1705
368-
continue
369-
370360
assert df_lhs == df_rhs, f"Difference in data_file column {df_column}: {df_lhs} != {df_rhs}"
371361
elif column == "readable_metrics":
372362
assert list(left.keys()) == [
@@ -887,7 +877,7 @@ def test_inspect_history(spark: SparkSession, session_catalog: Catalog, format_v
887877
if isinstance(left, float) and math.isnan(left) and isinstance(right, float) and math.isnan(right):
888878
# NaN != NaN in Python
889879
continue
890-
# assert left == right, f"Difference in column {column}: {left} != {right}"
880+
assert left == right, f"Difference in column {column}: {left} != {right}"
891881

892882

893883
@pytest.mark.integration
@@ -1094,7 +1084,6 @@ def test_inspect_all_files(
10941084

10951085

10961086
@pytest.mark.integration
1097-
@pytest.mark.skip("Fixed in https://github.com/apache/iceberg-rust/pull/1682/")
10981087
def test_inspect_files_format_version_3(spark: SparkSession, session_catalog: Catalog, arrow_table_with_null: pa.Table) -> None:
10991088
identifier = "default.table_metadata_files"
11001089

@@ -1140,9 +1129,7 @@ def test_inspect_files_format_version_3(spark: SparkSession, session_catalog: Ca
11401129

11411130

11421131
@pytest.mark.integration
1143-
# @pytest.mark.parametrize("format_version", [1, 2, 3])
1144-
# V3 support in https://github.com/apache/iceberg-rust/pull/1682/
1145-
@pytest.mark.parametrize("format_version", [1, 2])
1132+
@pytest.mark.parametrize("format_version", [1, 2, 3])
11461133
def test_inspect_files_partitioned(spark: SparkSession, session_catalog: Catalog, format_version: int) -> None:
11471134
from pandas.testing import assert_frame_equal
11481135

tests/utils/test_manifest.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ def _verify_metadata_with_fastavro(avro_file: str, expected_metadata: dict[str,
5858
assert metadata[k] == v
5959

6060

61-
@pytest.mark.skip("Fix in https://github.com/apache/iceberg-rust/pull/1705")
6261
def test_read_manifest_entry(generated_manifest_entry_file: str) -> None:
6362
manifest = ManifestFile.from_args(
6463
manifest_path=generated_manifest_entry_file,
@@ -308,9 +307,7 @@ def test_write_empty_manifest() -> None:
308307

309308

310309
@pytest.mark.parametrize("format_version", [1, 2])
311-
@pytest.mark.parametrize("compression", ["null", "deflate"])
312-
# Added in https://github.com/apache/iceberg-rust/pull/1692
313-
# @pytest.mark.parametrize("compression", ["null", "deflate", "zstd"])
310+
@pytest.mark.parametrize("compression", ["null", "deflate", "zstd"])
314311
def test_write_manifest(
315312
generated_manifest_file_file_v1: str,
316313
generated_manifest_file_file_v2: str,

0 commit comments

Comments
 (0)