Skip to content

table: skip validator registration for no-op producers. Parent: #830#1022

Open
hectar-glitches wants to merge 1 commit intoapache:mainfrom
hectar-glitches:main
Open

table: skip validator registration for no-op producers. Parent: #830#1022
hectar-glitches wants to merge 1 commit intoapache:mainfrom
hectar-glitches:main

Conversation

@hectar-glitches
Copy link
Copy Markdown

Summary

This PR gates validator registration on a new needsValidation() bool method on the producerImpl interface:

  • fastAppendFiles returns false: appends are commutative and need no conflict checks
  • mergeAppendFiles inherits false via embedding
  • overwriteFiles returns true: real conflict validation required
  • snapshotProducer.commit() skips registration when needsValidation() is false

The no-op validate() methods are kept as belt-and-suspenders.

Behavior is locked with two unit tests asserting that fast-append and merge-append commits leave txn.validators empty.

Parent: #830

…e#830

Signed-off-by: hectar-glitches <hectar@uni.minerva.edu>
@hectar-glitches hectar-glitches requested a review from zeroshade as a code owner May 6, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant