ci: split S3/MinIO into a Linux and macOS-only workflow#642
Merged
wgtmac merged 1 commit intoapache:mainfrom May 6, 2026
Merged
ci: split S3/MinIO into a Linux and macOS-only workflow#642wgtmac merged 1 commit intoapache:mainfrom
wgtmac merged 1 commit intoapache:mainfrom
Conversation
6f406c6 to
a600ef7
Compare
wgtmac
approved these changes
May 6, 2026
There was a problem hiding this comment.
Pull request overview
This PR addresses CI failures on Windows runners caused by the lack of a Windows-compatible minio/minio Docker image by decoupling S3/MinIO-backed testing from the main cross-platform workflow and running it only on Linux/macOS.
Changes:
- Made S3 support in the CI build script configurable (defaulting to OFF) so non-S3 workflows don’t build/run S3 tests.
- Removed MinIO startup and S3 environment variables from the main
test.ymlworkflow (including Windows). - Added a dedicated
s3_test.ymlworkflow that runs MinIO-backed S3 tests on Ubuntu and macOS only.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
ci/scripts/build_iceberg.sh |
Adds an explicit ICEBERG_S3 ON/OFF switch via a new positional argument so CI can disable S3 where unsupported. |
.github/workflows/test.yml |
Removes MinIO/S3 env and startup from the main test workflow to avoid Windows Docker manifest issues. |
.github/workflows/s3_test.yml |
Introduces a separate Linux/macOS workflow to run S3 integration tests against MinIO. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Currently the new split workflows still do the same thing. In the future we may use a dedicated script to build and run components relevant to AWS only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #640