mod_proxy_connect: Implement "AllowCONNECT None". - #719
Closed
notroj wants to merge 1 commit into
Closed
Conversation
notroj
commented
Aug 27, 2026
notroj
commented
Collaborator
The value is documented possibly by accident in r1932337, but not implemented. * modules/proxy/mod_proxy_connect.c (connect_conf): Add "none". (set_allowed_ports): Accept "None"; reject combining it with ports in the same context. (merge_config): Special-case "None": it disallows all ports and overrides an inherited list, and an inherited "None" is overridden by a port list in a vhost; two port lists still merge as a union. (allowed_port): Disallow all ports when "none" is set. * docs/manual/mod/mod_proxy_connect.xml: Clarify the merge behaviour and the "None" restriction. * test/modules/proxy/test_07_connect.py: Added. * test/modules/proxy/env.py: Load mod_proxy_connect for the suite. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.