Skip to content

mod_http2: fix test failures with recent nghttp2 releases #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
notroj wants to merge 2 commits into from
+22 −3
Closed

mod_http2: fix test failures with recent nghttp2 releases #713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3159f8
mod_http2: Don't abort a debug build over a stream reclaimed unproces…
notroj Aug 27, 2026
1e8a9a8
CI: Add a job running the mod_http2 tests against nghttp2 1.68.0.
notroj Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,19 @@ jobs:
NO_TEST_FRAMEWORK=1
TEST_PYTEST=1
# -------------------------------------------------------------------------
# nghttp2 promoted various stream errors to connection errors in
# 1.67.0, which mod_http2 handles differently; the runner image
# is still on 1.59, so build a newer release from source.
- name: mod_http2 w/nghttp2 1.68.0
config: --enable-mods-shared=reallyall --enable-maintainer-mode --with-mpm=event
pkgs: nghttp2-client
env: |
TEST_NGHTTP2=1.68.0
NO_TEST_FRAMEWORK=1
TEST_PYTEST=1
PYHTTPD_TARGETS=modules/http2
PYTEST_ARGS=--only=pyhttpd
# -------------------------------------------------------------------------
- name: Default
# -------------------------------------------------------------------------
- name: All-static modules
Expand Down
12 changes: 9 additions & 3 deletions modules/http2/h2_stream.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,9 +559,15 @@ static apr_status_t stream_pool_destroy(void *data)
h2_stream *stream = data;
switch (stream->magic) {
case H2_STRM_MAGIC_OK:
ap_log_cerror(APLOG_MARK, APLOG_ERR, 0, stream->session->c1,
H2_STRM_MSG(stream, "was not destroyed explicitly"));
AP_DEBUG_ASSERT(0);
/* Reclaimed with the session pool rather than destroyed
* explicitly. This is expected for a stream which was created
* but never scheduled for processing - e.g. one whose request
* nghttp2 rejects before it is handed to the mplx - and is
* harmless, since nothing but the session pool ever owned it.
* Use-after-free of a stream is still caught in any build by the
* H2_STRM_ASSERT_MAGIC at each use. */
ap_log_cerror(APLOG_MARK, APLOG_TRACE1, 0, stream->session->c1,
H2_STRM_MSG(stream, "reclaimed, never processed"));
break;
case H2_STRM_MAGIC_SDEL:
/* stream has been explicitly destroyed, as it should */
Expand Down