GUACAMOLE-2327: Report correct free space on large RDP redirected drives - #712
Merged
necouchman merged 1 commit intoSep 14, 2026
Merged
Conversation
benjefferies
changed the title
Contributor
|
@benjefferies Looks okay to me - can you rebase on |
benjefferies
force-pushed
the
rdp-drive-64bit-capacity
branch
from
September 14, 2026 15:51
4f2fe9c to
63dc06b
Compare
Contributor
Author
|
Rebased onto |
Contributor
Author
|
All done @necouchman |
Contributor
|
Sorry @benjefferies, one other request - your commit message needs to be tagged with |
cursor
Bot
force-pushed
the
rdp-drive-64bit-capacity
branch
from
September 14, 2026 16:55
63dc06b to
624c80b
Compare
RDPDR FileFsSizeInformation writes allocation-unit counts as UINT64, but guac_rdp_fs_info stored them in a 32-bit int. Filesystems with more than 2^31 allocation units then overflow, which can make Windows report zero free space and refuse copies onto the redirected drive. Related: GUACAMOLE-268, GUACAMOLE-764. Co-authored-by: Cursor <cursoragent@cursor.com>
cursor
Bot
force-pushed
the
rdp-drive-64bit-capacity
branch
from
September 14, 2026 17:01
624c80b to
50e24ff
Compare
Contributor
Author
|
Update commit message |
necouchman
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows Explorer can report no free space on an RDP-redirected Guacamole drive when the backing filesystem is large, even though writes that skip Explorer's pre-copy check still succeed. Copies of new files then fail with an insufficient-space error.
guac_rdp_fs_infostoredblocks_availableandblocks_totalasint.guac_rdp_fs_get_info()copiesstatvfscounts into those fields, and RDPDR later writes them as UINT64 (FileFsSizeInformation/FileFsFullSizeInformation). On filesystems with more than 2^31 allocation units, the 32-bit value overflows — often to zero — so Windows believes the drive is full.What changed
uint64_t, matching the RDPDR reply already being sent.Notes
Fixes: https://issues.apache.org/jira/browse/GUACAMOLE-2327