Skip to content

Restrict trigger push branch for GitHub Workflow#2648

Merged
paulk-asert merged 1 commit into
apache:masterfrom
apupier:restrictGitHubPushToSpecificBranch
Jun 30, 2026
Merged

Restrict trigger push branch for GitHub Workflow#2648
paulk-asert merged 1 commit into
apache:masterfrom
apupier:restrictGitHubPushToSpecificBranch

Conversation

@apupier

@apupier apupier commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Feature branches rarely need their own CI runs: the code is already tested when a pull request is opened against a release branch. If the push trigger has no branch restriction and pull_request is also configured, every push to a branch with an open PR runs the workflow twice: once for the push and once for the PR synchronisation.

Always give the push trigger an explicit list of branches: this stops branches created from a release branch from inheriting its workflow runs.

see https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=430408443#GitHubActionsRecommendedPractices-Restrictthepushtriggertospecificbranches

Feature branches rarely need their own CI runs: the code is already
tested when a pull request is opened against a release branch. If the
push trigger has no branch restriction and pull_request is also
configured, every push to a branch with an open PR runs the workflow
twice: once for the push and once for the PR synchronisation.

Always give the push trigger an explicit list of branches: this stops
branches created from a release branch from inheriting its workflow
runs.

see https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=430408443#GitHubActionsRecommendedPractices-Restrictthepushtriggertospecificbranches

Signed-off-by: Aurélien Pupier <apupier@ibm.com>
@paulk-asert paulk-asert merged commit f0095db into apache:master Jun 30, 2026
24 of 25 checks passed
@testlens-app

testlens-app Bot commented Jun 30, 2026

Copy link
Copy Markdown

🚨 TestLens detected 1 failed test 🚨

Here is what you can do:

  1. Inspect the test failures carefully.
  2. If you are convinced that some of the tests are flaky, you can mute them below.
  3. Finally, trigger a rerun by checking the rerun checkbox.

Test Summary

Build and test / lts (17, windows-latest, 1) > :test

Test Runs
AsyncAwaitSpecTest > testFastestServer()

🏷️ Commit: 1a86c6e
▶️ Tests: 17594 executed
🟡 Checks: 13/25 completed

Test Failures

AsyncAwaitSpecTest > testFastestServer() (:test in Build and test / lts (17, windows-latest, 1))
Assertion failed: 

assert response == 'fallback-response'
       |        |
       |        false
       'primary-response'

	at org.codehaus.groovy.runtime.InvokerHelper.createAssertError(InvokerHelper.java:400)
	at TestScript5.run(TestScript5.groovy:10)
	at groovy.lang.GroovyShell.evaluate(GroovyShell.java:553)
	at groovy.lang.GroovyShell.evaluate(GroovyShell.java:588)
	at groovy.lang.GroovyShell.evaluate(GroovyShell.java:572)
	at groovy.test.GroovyAssert.assertScript(GroovyAssert.java:106)
	at groovy.test.GroovyAssert.assertScript(GroovyAssert.java:96)
	at AsyncAwaitSpecTest.testFastestServer(AsyncAwaitSpecTest.groovy:122)

Muted Tests

Note

Checks are currently running using the configuration below.

Select tests to mute in this pull request:

🔲 AsyncAwaitSpecTest > testFastestServer()

Reuse successful test results:

🔲 ♻️ Only rerun the tests that failed or were muted before

Click the checkbox to trigger a rerun:

🔲 Rerun jobs


Learn more about TestLens at testlens.app.

@apupier apupier deleted the restrictGitHubPushToSpecificBranch branch June 30, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants