Skip to content

GROOVY-12117: adding tests for some edge cases#2646

Open
blackdrag wants to merge 1 commit into
masterfrom
feature/GROOVY-12117/edge_cases
Open

GROOVY-12117: adding tests for some edge cases#2646
blackdrag wants to merge 1 commit into
masterfrom
feature/GROOVY-12117/edge_cases

Conversation

@blackdrag

Copy link
Copy Markdown
Contributor

This test is an attempt to clarify some semantic gaps in our tests for traits

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: f27a508 Previous: 93f3d16 Ratio
org.apache.groovy.perf.grails.DynamicDispatchBench.methodMissingSavePattern 38.83550699247537 ms/op 23.4392629811486 ms/op 1.66

This comment was automatically generated by workflow using github-action-benchmark.

@codecov-commenter

codecov-commenter commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.5524%. Comparing base (c1f1e5e) to head (f27a508).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2646        +/-   ##
==================================================
+ Coverage     68.5485%   68.5524%   +0.0039%     
- Complexity      33744      33746         +2     
==================================================
  Files            1523       1523                
  Lines          127940     127940                
  Branches        23254      23254                
==================================================
+ Hits            87701      87706         +5     
+ Misses          32459      32455         -4     
+ Partials         7780       7779         -1     

see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

JMH summary — classic (commit 4bf7e7c)

Speedup vs trailing 90-day baseline on gh-pages. Higher = faster.
1.00 = in line with history. Per-benchmark ratio, geomean within group.
Time-per-op units inverted so direction is consistent.

Group Speedup n
bench 1.007 × 26
core 1.063 × 77
grails 0.977 × 80

Baseline: dev/bench/jmh/<part>/classic/data.js on gh-pages, trailing 90 days. Daily dashboard · Per-suite raw data

@github-actions

Copy link
Copy Markdown
Contributor

JMH summary — indy (commit 4bf7e7c)

Speedup vs trailing 90-day baseline on gh-pages. Higher = faster.
1.00 = in line with history. Per-benchmark ratio, geomean within group.
Time-per-op units inverted so direction is consistent.

Group Speedup n
bench 0.967 × 26
core 3.568 × 77
grails 2.271 × 80

Baseline: dev/bench/jmh/<part>/indy/data.js on gh-pages, trailing 90 days. Daily dashboard · Per-suite raw data

@testlens-app

testlens-app Bot commented Jun 30, 2026

Copy link
Copy Markdown

✅ All tests passed ✅

🏷️ Commit: f27a508
▶️ Tests: 98887 executed
⚪️ Checks: 31/31 completed


Learn more about TestLens at testlens.app.

@paulk-asert

Copy link
Copy Markdown
Contributor

@blackdrag I tried to merge these into the existing test hierarchy. Let me know if you spot any problems.
416652c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants