Repository navigation
fix(rust): replace unmaintained paste crate - #4183
Merged
chaokunyang merged 1 commit intoOct 16, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mohitjoshi-hey
requested review from
chaokunyang and
theweipeng
as code owners
October 15, 2026 22:37
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
cargo-denyreported the unmaintainedpastecrate (RUSTSEC-2024-0436) in the Rust dependency graph in issue #4182 .What does this PR do?
pastepackage with the maintainedpasteypackage through Cargo package renaming.paste, so the existing$crate::paste::paste!macro calls remain unchanged.rust/fory-core/Cargo.toml.Validation:
cargo test -p fory-core trait_visibility_forms_compile -- --nocapture— passed (1 passed, 0 failed).cargo clippy --workspace --all-features --all-targets -- -D warnings— passed.cargo tree --workspace | Select-String "paste"— showspastey v0.2.3and nopastecrate.cargo deny check— reportsadvisories ok,bans ok, andsources ok. The overall command reports license failures because this checkout has nodeny.tomland cargo-deny uses its default license policy.cargo test --workspace— all crates compiled, but one unrelated existing test,types::temporal::tests::std_time_conversions, failed inrust/fory-core/src/types/temporal.rs.Result:


Related issues
Fixes #4182
AI Contribution Checklist
yesyes, I included a completed AI Contribution Checklist and the required AI Usage Disclosure.yes, my PR description includes the requiredai_reviewsummary and final clean review evidence from both required reviewers.AI Usage Disclosure
rust/fory-core/Cargo.tomlpasteywith nopaste.pasteypackage.Completed AI Review Checklist
yesyes, I included the standardizedAI Usage Disclosureblock above.yes, I can explain and defend all important changes without AI help.yes, I reviewed AI-assisted code changes line by line before submission.yes, I completed line-by-line self-review first and fixed issues before requesting AI review.yes, I ran two fresh AI review agents on the current PR diff or current HEAD after the latest code changes: one Fory-guided reviewer and one independent general reviewer.yes, I addressed all actionable AI review comments and repeated the review loop until both AI reviewers reported no further actionable comments.yes, I attached screenshot evidence or equivalent persisted links of the final clean-review results from both reviewers in this PR body.yes, I ran a focused test command and recorded its result above.yes, I added regression tests for the reported issue.yes, I validated protocol and performance impacts; no binary protocol change was introduced.yes, I verified licensing and provenance compliance.Does this PR introduce any user-facing change?
This PR does not introduce any user-facing behavior, public API, or binary protocol changes.
Benchmark
Not applicable. This is a manifest-only dependency replacement and does not change serialization logic or runtime behavior.