[python] Remove PyFlink gateway fallback from AgentConfigOptions#867
Open
aka-dag wants to merge 1 commit into
Open
[python] Remove PyFlink gateway fallback from AgentConfigOptions#867aka-dag wants to merge 1 commit into
aka-dag wants to merge 1 commit into
Conversation
Python AgentConfigOptions used a metaclass to resolve missing options from Java via get_gateway(), which can fail during Pemja worker initialization. Declare config options explicitly in Python instead.
github-actions
Bot
added
doc-not-needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python AgentConfigOptions used a metaclass to resolve missing options from Java via get_gateway(), which can fail during Pemja worker initialization. Declare config options explicitly in Python instead.
Linked issue: #866
Purpose of change
Python
AgentConfigOptionsused a metaclass fallback to resolve missing options from Java throughpyflink.java_gateway.get_gateway(). This can start a PyFlink gateway while importing runtime modules inside the Pemja worker.This change removes the Java-backed dynamic lookup and declares Python config options explicitly.
Tests
get_gateway()../tools/ut.sh -p../tools/lint.sh.API
This changes the implementation of Python
AgentConfigOptions. Publicly supported options remain accessible as explicit PythonConfigOptiondeclarations. Dynamic access to Java-only options is removed.Documentation
doc-neededdoc-not-neededdoc-included