Skip to content

perf: add sort-serving segments index for KillUnusedSegments query #19645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jtuglu1 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

perf: add sort-serving segments index for KillUnusedSegments query #19645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions server/src/main/java/org/apache/druid/metadata/SQLMetadataConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,22 @@ tableName, getPayloadType(), getQuoteString(), getCollation()
"start"
)
);
// Sort-serving index for KillUnusedSegments' find-interval query
// (WHERE dataSource=? AND used=? AND end<=? [AND start>=?] ORDER BY start, end LIMIT n).
// Leading (dataSource, used) equality + (start, end) matches the ORDER BY, so MySQL avoids a
// filesort and the LIMIT short-circuits the scan; used_status_last_updated trailing makes the
// query covering. See SqlSegmentsMetadataQuery#retrieveUnusedSegmentIntervals.
createIndex(
tableName,
"IDX_%S_DATASOURCE_USED_START_END_LASTUPDATED",
List.of(
"dataSource",
"used",
"start",
quoteColumn("end"),
"used_status_last_updated"
)
);
}

private void createUpgradeSegmentsTable(final String tableName)
Expand Down Expand Up @@ -663,6 +679,17 @@ protected void alterSegmentTable()
"IDX_%S_DATASOURCE_UPGRADED_FROM_SEGMENT_ID",
List.of("dataSource", "upgraded_from_segment_id")
);
createIndex(
tableName,
"IDX_%S_DATASOURCE_USED_START_END_LASTUPDATED",
List.of(
"dataSource",
"used",
"start",
quoteColumn("end"),
"used_status_last_updated"
)
);
}

@Override
Expand Down
12 changes: 8 additions & 4 deletions server/src/test/java/org/apache/druid/metadata/SQLMetadataConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,8 @@ public void test_useShortIndexNames_true_tableIndices_areNotAdded_ifExist()
final Set<String> expectedIndices = Sets.newHashSet(
"IDX_DRUIDTEST_SEGMENTS_USED",
"IDX_D011BD6ED76268701273CE512704C5AFA060D672",
"IDX_6381EF2DB4824C35C0E72EF9E166626ADB2B21A3"
"IDX_6381EF2DB4824C35C0E72EF9E166626ADB2B21A3",
"IDX_CF2F89C27777DAB744431580CD9C78D5365CC53A"
);
assertIndicesPresentOnTable(segmentsTable, expectedIndices);

Expand Down Expand Up @@ -383,7 +384,8 @@ public void test_useShortIndexNames_false_tableIndices_areNotAdded_ifExist()
final Set<String> expectedIndices = Sets.newHashSet(
"IDX_8FE3D20EC8C9CA932EA3FF6AC497D1A9E75ADDA0",
"IDX_DRUIDTEST_SEGMENTS_DATASOURCE_USED_END_START",
"IDX_DRUIDTEST_SEGMENTS_DATASOURCE_UPGRADED_FROM_SEGMENT_ID"
"IDX_DRUIDTEST_SEGMENTS_DATASOURCE_UPGRADED_FROM_SEGMENT_ID",
"IDX_DRUIDTEST_SEGMENTS_DATASOURCE_USED_START_END_LASTUPDATED"
);
assertIndicesPresentOnTable(segmentsTable, expectedIndices);

Expand All @@ -407,7 +409,8 @@ public void test_useShortIndexNames_true_tableIndices_areAdded_IfNotExist()
final Set<String> expectedIndices = Sets.newHashSet(
"IDX_8FE3D20EC8C9CA932EA3FF6AC497D1A9E75ADDA0",
"IDX_D011BD6ED76268701273CE512704C5AFA060D672",
"IDX_6381EF2DB4824C35C0E72EF9E166626ADB2B21A3"
"IDX_6381EF2DB4824C35C0E72EF9E166626ADB2B21A3",
"IDX_CF2F89C27777DAB744431580CD9C78D5365CC53A"
);

connector.createSegmentTable(segmentsTable);
Expand All @@ -433,7 +436,8 @@ public void test_useShortIndexNames_false_tableIndices_areAdded_IfNotExist()
final Set<String> expectedIndices = Sets.newHashSet(
"IDX_DRUIDTEST_SEGMENTS_USED",
"IDX_DRUIDTEST_SEGMENTS_DATASOURCE_USED_END_START",
"IDX_DRUIDTEST_SEGMENTS_DATASOURCE_UPGRADED_FROM_SEGMENT_ID"
"IDX_DRUIDTEST_SEGMENTS_DATASOURCE_UPGRADED_FROM_SEGMENT_ID",
"IDX_DRUIDTEST_SEGMENTS_DATASOURCE_USED_START_END_LASTUPDATED"
);

connector.createSegmentTable(segmentsTable);
Expand Down
Loading