Skip to content

[fix](fe) Validate ngram search gram number #67749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mryange wants to merge 1 commit into
base: master
Choose a base branch
from
+25 −7
Open

[fix](fe) Validate ngram search gram number #67749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions ...rc/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/NgramSearch.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import org.apache.doris.nereids.trees.expressions.Expression;
import org.apache.doris.nereids.trees.expressions.functions.ExplicitlyCastableSignature;
import org.apache.doris.nereids.trees.expressions.functions.PropagateNullable;
import org.apache.doris.nereids.trees.expressions.literal.IntegerLikeLiteral;
import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor;
import org.apache.doris.nereids.types.DoubleType;
import org.apache.doris.nereids.types.IntegerType;
Expand All @@ -47,19 +48,28 @@ public class NgramSearch extends ScalarFunction
*/
public NgramSearch(Expression arg0, Expression arg1, Expression arg2) {
super("ngram_search", arg0, arg1, arg2);
if (!(arg1.isConstant())) {
}

/** constructor for withChildren and reuse signature */
private NgramSearch(ScalarFunctionParams functionParams) {
super(functionParams);
}

@Override
public void checkLegalityBeforeTypeCoercion() {
if (!child(1).isConstant()) {
throw new AnalysisException(
"ngram_search(text,pattern,gram_num): pattern support const value only.");
}
if (!(arg2.isConstant())) {
Expression gramNum = child(2);
if (!gramNum.isConstant()) {
throw new AnalysisException(
"ngram_search(text,pattern,gram_num): gram_num support const value only.");
}
}

/** constructor for withChildren and reuse signature */
private NgramSearch(ScalarFunctionParams functionParams) {
super(functionParams);
if (!(gramNum instanceof IntegerLikeLiteral) || ((IntegerLikeLiteral) gramNum).getIntValue() <= 0) {
throw new AnalysisException(
"ngram_search(text,pattern,gram_num): gram_num must be a positive constant.");
}
}

/**
Expand Down
8 changes: 8 additions & 0 deletions regression-test/suites/query_p0/sql_functions/string_functions/test_string_function.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,14 @@ suite("test_string_function", "arrow_flight_sql") {
qt_ngram_search2 """select ngram_search('abc','abc1313131',3); """
qt_ngram_search3 """select ngram_search('abc1313131','abc1313131',3); """
qt_ngram_search3 """select ngram_search('1313131','abc1313131',3); """
test {
sql "select ngram_search('abc', 'abc', 0);"
exception "gram_num must be a positive constant"
}
test {
sql "select ngram_search('abc', 'abc', -1);"
exception "gram_num must be a positive constant"
}


sql "drop table if exists test_function_ngram_search;";
Expand Down