Skip to content

[fix](expression) Align signed zero constant comparisons #67748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mryange wants to merge 1 commit into
base: master
Choose a base branch
from
+24 −1
Open

[fix](expression) Align signed zero constant comparisons #67748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/NumericLiteral.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,10 @@ public int compareTo(ComparableLiteral other) {
|| other instanceof DecimalLiteral || other instanceof DecimalV3Literal) {
return this.getBigDecimalValue().compareTo(((NumericLiteral) other).getBigDecimalValue());
}
return Double.compare(this.getDouble(), ((Literal) other).getDouble());
double left = this.getDouble();
double right = ((Literal) other).getDouble();
// SQL treats signed zeros as equal, while Double.compare distinguishes them.
return left == right ? 0 : Double.compare(left, right);
}
if (other instanceof NullLiteral) {
return 1;
Expand Down
20 changes: 20 additions & 0 deletions fe/fe-core/src/test/java/org/apache/doris/nereids/rules/expression/FoldConstantTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,26 @@

class FoldConstantTest extends ExpressionRewriteTestHelper {

@Test
void testSignedZeroComparisonFold() {
executor = new ExpressionRuleExecutor(ImmutableList.of(
bottomUp(FoldConstantRuleOnFE.VISITOR_INSTANCE)
));
for (String type : ImmutableList.of("float", "double")) {
for (String zero : ImmutableList.of("0.0", "-0.0")) {
String left = "cast('" + zero + "' as " + type + ")";
String right = "cast('" + (zero.equals("0.0") ? "-0.0" : "0.0") + "' as " + type + ")";
assertRewriteAfterTypeCoercion(left + " = " + right, "true");
assertRewriteAfterTypeCoercion(left + " <=> " + right, "true");
assertRewriteAfterTypeCoercion(left + " != " + right, "false");
assertRewriteAfterTypeCoercion(left + " < " + right, "false");
assertRewriteAfterTypeCoercion(left + " > " + right, "false");
assertRewriteAfterTypeCoercion(left + " <= " + right, "true");
assertRewriteAfterTypeCoercion(left + " >= " + right, "true");
}
}
}

@Test
void testCaseWhenFold() {
executor = new ExpressionRuleExecutor(ImmutableList.of(
Expand Down
Loading