branch-4.1: [perf](load) Optimize write performance with improved backpressure control - #67728
Open
sollhui wants to merge 1 commit into
Open
branch-4.1: [perf](load) Optimize write performance with improved backpressure control#67728sollhui wants to merge 1 commit into
sollhui wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Backport #66847 to branch-4.1.
For S3-backed cloud loads, a memtable flush can finish after submitting asynchronous uploads, so flush-running count does not represent downstream upload pressure. This change detects S3 storage and uses the S3 upload queue for backpressure, falling back to the existing flush-running limit when the upload pool is unavailable. HDFS retains flush-count backpressure.
Branch-4.1 adaptation
branch-4.1 does not contain WriteRequestType::GROUP or CloudGroupRowsetBuilder. The row-binlog GROUP-specific changes from the original PR are therefore omitted. CloudRowsetBuilder is final in this branch, so is_s3_storage is non-virtual. Local-storage flush limits remain unchanged.
Release note
Improve load backpressure for S3-backed cloud loads. Higher concurrency can increase memory use.
Check List (For Author)