Skip to content

[Chore] Change required_approving_review_count to 1#17992

Merged
Gallardot merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_changeMinApproveTo1
Feb 25, 2026
Merged

[Chore] Change required_approving_review_count to 1#17992
Gallardot merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_changeMinApproveTo1

Conversation

@ruanwenjun
Copy link
Copy Markdown
Member

@ruanwenjun ruanwenjun commented Feb 24, 2026

Was this PR generated or assisted by AI?

No

Purpose of the pull request

We don't have enough active committers, it's better to set required_approving_review_count to 1 to make sure the PR can be merged smoothly.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@ruanwenjun ruanwenjun added this to the 3.4.1 milestone Feb 24, 2026
Copy link
Copy Markdown
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link
Copy Markdown

@ruanwenjun ruanwenjun changed the title [Chore] Change dismiss_stale_reviews to 1 [Chore] Change required_approving_review_count to 1 Feb 25, 2026
@Gallardot Gallardot merged commit 17d853a into apache:dev Feb 25, 2026
76 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants