Skip to content

[Fix-17915][alert] Fix the issue of setting timeout exceptions in the HTTP alert plugin, where the unit in the code is not consistent with the page.#17910

Closed
maomao199691 wants to merge 0 commit intoapache:devfrom
maomao199691:dev-maomao
Closed

[Fix-17915][alert] Fix the issue of setting timeout exceptions in the HTTP alert plugin, where the unit in the code is not consistent with the page.#17910
maomao199691 wants to merge 0 commit intoapache:devfrom
maomao199691:dev-maomao

Conversation

@maomao199691
Copy link
Copy Markdown
Contributor

@maomao199691 maomao199691 commented Jan 27, 2026

… where the unit in the code is not consistent with the page.

Purpose of the pull request

The purpose of this pull request is to address the issue where the timeout duration (in seconds) for HTTP alerts is not taking effect in the code.

fix #17915

Brief change log

The modifications have been made in the HTTP alarm plugin

Verify this pull request

This change added tests and can be verified as follows:

  • Manually verified the change by testing locally. -->

before modification:

<img width="788" height="796" alt="image" src="https://github.com/user-attachments/assets/73ef91a5-cbdc-44b3-bf36-4276c8b2a8f9" /
Snipaste_2026-01-27_19-02-08

modified:
Snipaste_2026-01-27_19-06-45

@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented Jan 27, 2026

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

@SbloodyS
Copy link
Copy Markdown
Member

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

Please follow the pull request notice and create an issue first.

@maomao199691
Copy link
Copy Markdown
Contributor Author

感谢您提交此拉取请求!请查看我们的贡献指南。(https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

I have created an issue [Fix-17915]

@maomao199691 maomao199691 changed the title Fix the issue of setting timeout exceptions in the HTTP alert plugin,… [Fix-17915][alert] Fix the issue of setting timeout exceptions in the HTTP alert plugin, where the unit in the code is not consistent with the page. Jan 29, 2026
@SbloodyS SbloodyS added bug Something isn't working first time contributor First-time contributor labels Jan 30, 2026
@SbloodyS SbloodyS added this to the 3.4.1 milestone Jan 30, 2026

String bodyParamsString = paramsMap.get(HttpAlertConstants.NAME_BODY_PARAMS);
if (StringUtils.isNotBlank(bodyParamsString)) {
// bodyParams = JSONUtils.toMap(bodyParamsString);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid unnessnary change.

String valueOf = String.valueOf(value);
if (valueOf.contains(HttpAlertConstants.MSG_PARAMS)) {
bodyParams.put(key, valueOf.replace(HttpAlertConstants.MSG_PARAMS, msg));

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend bug Something isn't working first time contributor First-time contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][Alert] The alarm timeout time unit for the HTTP plugin is incorrect

2 participants