[Feature-17566][Helm] add secrets and initContainers in worker statefulset by jmmc-tools · Pull Request #17519 · apache/dolphinscheduler

jmmc-tools · 2025-09-16T15:54:06Z

=== NEW feature: secrets support ===

Configuration example in values.yaml

worker:
  enabled: true
  replicas: 3
  # option: only 1 secret (for the most cases)
  # This secret have the all credential/token values need for use in worker pods.
  envFromSecret: "git-sync-secret"

=== NEW feature: add use initContainers

# Configuration example
worker:
  enabled: true
  replicas: 1
  # Init Container example in values.yaml
  initContainers:
    - name: secrets-decoder
      image: busybox:latest
      command:
        - /bin/sh
        - -c
        - |
          set -e
          echo "🔐 example initContainer for worker..."

Purpose of the pull request

This pull request adds new features in values yaml for worker pods from kubernetes:

initContainer
secretName

Brief change log

Verify this pull request

Manually verified the change by testing locally. -->

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

boring-cyborg · 2025-09-16T15:54:09Z

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

jmmc-tools · 2025-10-01T20:25:31Z

@ruanwenjun could you review changes ? I have changed a better tittle but doesn't pass a couple of validators

SbloodyS · 2025-10-05T02:09:50Z

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

Please follow pull request notice and create an feature issue first. @jmmc-tools

jmmc-tools · 2025-10-07T08:40:06Z

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

Please follow pull request notice and create an feature issue first. @jmmc-tools

Sure, I open #17566

Gallardot

LGTM. Thanks @jmmc-tools

Do other components such as master or API-server also need this feature?

jmmc-tools · 2025-10-08T14:06:27Z

It's not mandatory to add more components for this feature request.

The current scope focuses on the specific worker component, and extending it to master or API-server would be a separate consideration that could be evaluated in future iterations if needed.

SbloodyS

+1

Gallardot

LGTM. However, we need to update the values.yaml file at the same time so that users know about this feature.

add secrets for worker statafulset in values yaml # Configuración existente del worker worker: enabled: true replicas: 3 # === NUEVA FUNCIONALIDAD: Soporte para secrets === # Opción 1: Un solo secret (recomendado para la mayoría de casos) # Este secret contendrá todas las variables de entorno necesarias envFromSecret: "git-sync-secret"

add feature to use initContainers in values yaml

[Feature-17566][Helm] update values example for secrets and initContainers

jmmc-tools · 2025-10-13T16:55:59Z

@Gallardot @ruanwenjun could you review values changes? thanks!!

Co-authored-by: Gallardot <gallardot@apache.org>

jmmc-tools · 2025-11-06T16:56:12Z

@ruanwenjun could you review latest changes? thanks!

Gallardot · 2025-11-07T05:40:26Z

+  # -- Init Container for Advanced Processing
+  # Use when you need to transform, validate, or prepare configuration files
+  initContainers: {}
+    - name: config-processor


This is a good example, but it should not be set as the default value for initcontainers. Instead, it should be treated as a comment.

This is a good example, but it should not be set as the default value for initcontainers. Instead, it should be treated as a comment.

Now it's fixed

initContainers is now optional with comments.

Gallardot

LGTM

jmmc-tools · 2025-11-17T13:19:09Z

@ruanwenjun could you review PR? Thanks!

SbloodyS

+1

SbloodyS · 2025-11-18T03:14:27Z

Please fix helm doc CI error. @jmmc-tools

sonarqubecloud · 2025-11-18T23:05:17Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

jmmc-tools · 2025-11-19T07:33:48Z

Please fix helm doc CI error. @jmmc-tools

@SbloodyS now it's fixed. Thanks

boring-cyborg · 2025-11-19T08:36:37Z

Awesome work, congrats on your first merged pull request!

jmmc-tools requested a review from Gallardot as a code owner September 16, 2025 15:54

github-actions Bot added the kubernetes label Sep 16, 2025

github-actions Bot assigned jmmc-tools Sep 16, 2025

jmmc-tools changed the title ~~Update statefulset-dolphinscheduler-worker.yaml~~ Improvement statefulset-dolphinscheduler-worker.yaml Sep 17, 2025

ruanwenjun added the improvement make more easy to user or prompt friendly label Sep 20, 2025

ruanwenjun added this to the 3.3.2 milestone Sep 20, 2025

ruanwenjun force-pushed the patch-1 branch from 6b06ab2 to 6f2c729 Compare September 20, 2025 04:46

jmmc-tools changed the title ~~Improvement statefulset-dolphinscheduler-worker.yaml~~ [ Enhancement ] new feature: secrets and initContainers Sep 30, 2025

jmmc-tools changed the title ~~[ Enhancement ] new feature: secrets and initContainers~~ [ Feature ] [#17566] new feature: secrets and initContainers Oct 7, 2025

jmmc-tools changed the title ~~[ Feature ] [#17566] new feature: secrets and initContainers~~ [ Feature ] [ #17566 ] new feature: secrets and initContainers Oct 7, 2025

SbloodyS changed the title ~~[ Feature ] [ #17566 ] new feature: secrets and initContainers~~ [Feature-17566 ][Helm] add secrets and initContainers in worker statefulset Oct 8, 2025

SbloodyS changed the title ~~[Feature-17566 ][Helm] add secrets and initContainers in worker statefulset~~ [Feature-17566][Helm] add secrets and initContainers in worker statefulset Oct 8, 2025

Gallardot reviewed Oct 8, 2025

View reviewed changes

SbloodyS previously approved these changes Oct 9, 2025

View reviewed changes

SbloodyS requested a review from ruanwenjun October 9, 2025 01:30

Gallardot approved these changes Oct 9, 2025

View reviewed changes

Gallardot requested changes Oct 9, 2025

View reviewed changes

jmmc-tools added 2 commits October 9, 2025 17:27

add initContainers statefulset-dolphinscheduler-worker.yaml

19674f1

add feature to use initContainers in values yaml

ruanwenjun force-pushed the patch-1 branch from bdafd9d to 19674f1 Compare October 9, 2025 09:28

ruanwenjun and others added 2 commits October 9, 2025 23:20

Merge branch 'dev' into patch-1

3a69c4e

[Feature-17566] update values.yaml

00454c3

[Feature-17566][Helm] update values example for secrets and initContainers

jmmc-tools dismissed SbloodyS’s stale review via 00454c3 October 13, 2025 16:51

Merge branch 'dev' into patch-1

69a9edf

Merge branch 'dev' into patch-1

3d0f0f3

Gallardot requested changes Oct 16, 2025

View reviewed changes

Comment thread deploy/kubernetes/dolphinscheduler/values.yaml Outdated

Comment thread deploy/kubernetes/dolphinscheduler/values.yaml Outdated

Comment thread deploy/kubernetes/dolphinscheduler/templates/statefulset-dolphinscheduler-worker.yaml

SbloodyS modified the milestones: 3.3.2, 3.3.3 Oct 21, 2025

jmmc-tools and others added 3 commits October 28, 2025 21:18

Actualizar values.yaml

dfb5cb2

Co-authored-by: Gallardot <gallardot@apache.org>

Actualizar values.yaml

07b7c2b

Co-authored-by: Gallardot <gallardot@apache.org>

Merge branch 'dev' into patch-1

361bb7c

Gallardot requested changes Nov 7, 2025

View reviewed changes

jmmc-tools and others added 3 commits November 11, 2025 17:32

Fix initContainer comments in values.yaml

66a1396

initContainers is now optional with comments.

Merge branch 'dev' into patch-1

90200a4

Merge branch 'dev' into patch-1

0c5ef1c

Gallardot previously approved these changes Nov 17, 2025

View reviewed changes

SbloodyS previously approved these changes Nov 18, 2025

View reviewed changes

jmmc-tools added 2 commits November 18, 2025 09:52

Merge branch 'dev' into patch-1

2452d7b

helm-docs update [Improvement-17573]

ff44882

jmmc-tools dismissed stale reviews from Gallardot and SbloodyS via ff44882 November 18, 2025 09:52

github-actions Bot added the document label Nov 18, 2025

SbloodyS approved these changes Nov 19, 2025

View reviewed changes

SbloodyS requested a review from Gallardot November 19, 2025 01:30

jmmc-tools requested a review from SbloodyS November 19, 2025 07:34

SbloodyS approved these changes Nov 19, 2025

View reviewed changes

Gallardot approved these changes Nov 19, 2025

View reviewed changes

SbloodyS merged commit 67b9a80 into apache:dev Nov 19, 2025
77 of 100 checks passed

Conversation

jmmc-tools commented Sep 16, 2025 • edited by SbloodyS Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

=== NEW feature: secrets support ===

Configuration example in values.yaml

=== NEW feature: add use initContainers

Purpose of the pull request

Brief change log

Verify this pull request

Pull Request Notice

Uh oh!

boring-cyborg Bot commented Sep 16, 2025

Uh oh!

jmmc-tools commented Oct 1, 2025

Uh oh!

SbloodyS commented Oct 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmmc-tools commented Oct 7, 2025

Uh oh!

Gallardot left a comment

Choose a reason for hiding this comment

Uh oh!

jmmc-tools commented Oct 8, 2025

Uh oh!

SbloodyS left a comment

Choose a reason for hiding this comment

Uh oh!

Gallardot left a comment

Choose a reason for hiding this comment

Uh oh!

jmmc-tools commented Oct 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmmc-tools commented Nov 6, 2025

Uh oh!

Gallardot Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

jmmc-tools Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Gallardot left a comment

Choose a reason for hiding this comment

Uh oh!

jmmc-tools commented Nov 17, 2025

Uh oh!

SbloodyS left a comment

Choose a reason for hiding this comment

Uh oh!

SbloodyS commented Nov 18, 2025

Uh oh!

sonarqubecloud Bot commented Nov 18, 2025

Quality Gate passed

Uh oh!

jmmc-tools commented Nov 19, 2025

Uh oh!

Uh oh!

boring-cyborg Bot commented Nov 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jmmc-tools commented Sep 16, 2025 •

edited by SbloodyS

Loading

SbloodyS commented Oct 5, 2025 •

edited

Loading