[Improvement-16994][TaskPlugin] ensure spark application cancelled#17504
Closed
abzymeatsjtu wants to merge 1 commit intoapache:devfrom
Closed
[Improvement-16994][TaskPlugin] ensure spark application cancelled#17504abzymeatsjtu wants to merge 1 commit intoapache:devfrom
abzymeatsjtu wants to merge 1 commit intoapache:devfrom
Conversation
abzymeatsjtu
requested review from
Gallardot,
SbloodyS and
caishunfeng
as code owners
ruanwenjun
reviewed
Sep 11, 2025
Comment on lines
+217
to
+228
|
|
||
| RunState currentState = RunState.Cancelling; | ||
|
|
||
| while (!RunState.isCancelled(currentState)) { | ||
| currentState = RunState.valueOf(pollJobRunStatus()); | ||
|
|
||
| try { | ||
| Thread.sleep(10 * 1000L); | ||
| } catch (InterruptedException e) { | ||
| break; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
We don't need to do this change, since the kill operation is async, and only handle finish, then the worker will return the task state to master. The change might block a thread.
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
|
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs. |
|
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ensure spark application cancelled when cancel application is triggered
close #16994