Skip to content

[Improvement-17485][Master] Change batchTriggerAcquisitionMaxCount default value equals to threadCount#17483

Merged
ruanwenjun merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_changeBatchTriggerAcquisitionMaxCountDefaultValue
Sep 15, 2025
Merged

[Improvement-17485][Master] Change batchTriggerAcquisitionMaxCount default value equals to threadCount#17483
ruanwenjun merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_changeBatchTriggerAcquisitionMaxCountDefaultValue

Conversation

@ruanwenjun
Copy link
Copy Markdown
Member

@ruanwenjun ruanwenjun commented Sep 8, 2025

Purpose of the pull request

close #17485

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@ruanwenjun ruanwenjun marked this pull request as draft September 8, 2025 06:32
@ruanwenjun ruanwenjun changed the title Change org.quartz.scheduler.batchTriggerAcquisitionMaxCount default value equals to org.quartz.threadPool.threadCount [Improvement-17485][Master] Change org.quartz.scheduler.batchTriggerAcquisitionMaxCount default value equals to org.quartz.threadPool.threadCount Sep 8, 2025
@ruanwenjun ruanwenjun changed the title [Improvement-17485][Master] Change org.quartz.scheduler.batchTriggerAcquisitionMaxCount default value equals to org.quartz.threadPool.threadCount [Improvement-17485][Master] Change batchTriggerAcquisitionMaxCount default value equals to org.quartz.threadPool.threadCount Sep 8, 2025
@ruanwenjun ruanwenjun changed the title [Improvement-17485][Master] Change batchTriggerAcquisitionMaxCount default value equals to org.quartz.threadPool.threadCount [Improvement-17485][Master] Change batchTriggerAcquisitionMaxCount default value equals to threadCount Sep 8, 2025
@ruanwenjun ruanwenjun marked this pull request as ready for review September 8, 2025 11:31
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_changeBatchTriggerAcquisitionMaxCountDefaultValue branch from 9bb8706 to 0a6789a Compare September 8, 2025 11:31
@ruanwenjun
Copy link
Copy Markdown
Member Author

In our environment tests, this parameter can increase performance by more than ten times.

@ruanwenjun ruanwenjun added the improvement make more easy to user or prompt friendly label Sep 8, 2025
@SbloodyS SbloodyS added this to the 3.3.2 milestone Sep 9, 2025
Copy link
Copy Markdown
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_changeBatchTriggerAcquisitionMaxCountDefaultValue branch from 0a6789a to 1167a12 Compare September 11, 2025 15:02
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_changeBatchTriggerAcquisitionMaxCountDefaultValue branch from 1167a12 to e04d943 Compare September 15, 2025 08:23
…alue equals to org.quartz.threadPool.threadCount
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_changeBatchTriggerAcquisitionMaxCountDefaultValue branch from e04d943 to 1498ac6 Compare September 15, 2025 13:27
@sonarqubecloud
Copy link
Copy Markdown

@ruanwenjun ruanwenjun merged commit ea4efd8 into apache:dev Sep 15, 2025
74 of 94 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_changeBatchTriggerAcquisitionMaxCountDefaultValue branch September 15, 2025 15:00
davidzollo pushed a commit to davidzollo/dolphinscheduler that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend e2e e2e test improvement make more easy to user or prompt friendly ready-to-merge test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement][Master] Parallel handle trigger enabled by default

3 participants