perf: Compute array_length of first dimension from offsets - #25121
Open
neilconway wants to merge 2 commits into
Open
perf: Compute array_length of first dimension from offsets#25121neilconway wants to merge 2 commits into
array_length of first dimension from offsets#25121neilconway wants to merge 2 commits into
Conversation
AdamGS
approved these changes
Sep 9, 2026
AdamGS
left a comment
Contributor
There was a problem hiding this comment.
awesome improvement, LGTM!
Rich-T-kid
approved these changes
Sep 9, 2026
Contributor
Author
|
@AdamGS @Rich-T-kid Thanks for the reviews! |
neilconway
enabled auto-merge
September 9, 2026 19:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
array_lengthfrom offsets #25119.Rationale for this change
array_lengthworked by forming a slice of values for each logical row in the given dimension, and then appending the length of that slice to the result. That is inefficient; when computing the length of the first array dimension, we can get that from the offset buffer instead, which is ~200x faster for typical inputs. For other array dimensions, we fallback to the previous code path.Benchmarks: (M4 Max)
What changes are included in this PR?
array_lengthof dimension 1 forListandLargeListfrom offsetsarray_lengthof dimension 1 forFixedSizeListfrom the FSL's sizearray_length(x, 1)as equivalent toarray_length(x)array_lengthWhat is the testing strategy for this PR?
Existing tests pass; new unit tests added.
Are there any user-facing changes?
No.