Skip to content

fix: resolve DST-ambiguous and nonexistent local times when casting naive timestamps to a named timezone #25115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adriangb wants to merge 1 commit into from
+655 −0
Closed

fix: resolve DST-ambiguous and nonexistent local times when casting naive timestamps to a named timezone #25115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions datafusion/common/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ pub mod scalar;
pub mod spans;
pub mod stats;
pub mod test_util;
pub mod timezone_cast;
pub mod tree_node;
pub mod types;
pub mod utils;
Expand Down
12 changes: 12 additions & 0 deletions datafusion/common/src/scalar/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4440,6 +4440,18 @@ impl ScalarValue {
target_type,
) {
crate::nested_struct::cast_column(&scalar_array, target_type, cast_options)?
} else if crate::timezone_cast::is_naive_to_timezone_cast(
&source_type,
target_type,
) {
// Casting a timezone-naive timestamp into a timezone follows
// PostgreSQL/DuckDB semantics around daylight saving transitions,
// which differ from arrow's kernel.
crate::timezone_cast::cast_naive_timestamp_to_timezone(
&scalar_array,
target_type,
cast_options,
)?
} else {
cast_with_options(&scalar_array, target_type, cast_options)?
};
Expand Down
Loading