fix: preserve scalar UDF strictness across FFI - #25109
Open
emecii wants to merge 1 commit into
Open
Conversation
Forward ScalarUDFImpl::is_strict through FFI_ScalarUDF and cover both forced-foreign and cross-library round trips. Generated-by: Codex (GPT-5)
Author
|
@timsaucer, could you please add the required AI-generated with Codex (GPT-5). |
Member
|
This looks very straight forward. Can you clean up the PR description, though? There's a bit of slop in it. |
Author
|
Cleaned up the description and removed the local environment details. Thanks. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25109 +/- ##
==========================================
- Coverage 81.80% 81.80% -0.01%
==========================================
Files 1130 1130
Lines 417754 417765 +11
Branches 417754 417765 +11
==========================================
Hits 341754 341754
- Misses 55875 55881 +6
- Partials 20125 20130 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
FFI_ScalarUDFsilently drops producer overrides of defaulted trait methods #22330.Rationale for this change
Foreign scalar UDFs currently lose their
is_strict()value across the FFI boundary. The consumer therefore reportsfalse, preventing optimizer rules from using the provider's nullability metadata.What changes are included in this PR?
is_strictcallback toFFI_ScalarUDF.ForeignScalarUDF.What is the testing strategy for this PR?
cargo test -p datafusion-ffi --features integration-testscargo fmt --all -- --checkThe FFI test suite passes with 122 unit tests plus the integration targets.
Are there any user-facing changes?
Yes. Foreign scalar UDFs now preserve strictness metadata. The
FFI_ScalarUDFlayout changes, so this PR requires theapi changelabel.