fix(build): resolve rat license-check paths against project root#53
Open
InbalHoni wants to merge 1 commit into
Open
fix(build): resolve rat license-check paths against project root#53InbalHoni wants to merge 1 commit into
InbalHoni wants to merge 1 commit into
Conversation
The :rat task used relative paths, which the Gradle daemon's embedded Ant builder resolves against the daemon working directory (~/.gradle/daemon/5.6.4/) instead of the project root - so it scanned the wrong directory and could not find the report stylesheet, failing `./gradlew clean assemble`. Switched to absolute paths (project.projectDir / project.buildDir). Verified `assemble` now passes with :rat succeeding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
:rattask used relative paths, which the Gradle daemon's embedded Ant builder resolves against the daemon working directory (~/.gradle/daemon/5.6.4/) instead of the project root - so it scanned the wrong directory and could not find the report stylesheet, failing./gradlew clean assemble.Switched to absolute paths (
project.projectDir/project.buildDir). Verifiedassemblenow passes with:ratsucceeding.