Fix encrypted properties tests to work with WSS4J 4.0.2 - #3458
Open
coheigea wants to merge 1 commit into
Open
Conversation
reta
reviewed
Sep 9, 2026
| ((java.io.Closeable)port).close(); | ||
| bus.shutdown(true); | ||
| try { | ||
| if (!JavaUtils.isFIPSEnabled()) { |
Member
There was a problem hiding this comment.
@coheigea may I suggest please to have two independent test runs in Maven, non-FIPs as defaut:
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<executions>
<execution>
<id>default-test</id>
<configuration>
<systemPropertyVariables>
<org.apache.wss4j.crypto.jasypt.useLegacyDefaultAlgorithm>true</org.apache.wss4j.crypto.jasypt.useLegacyDefaultAlgorithm>
</systemPropertyVariables>
</configuration>
</execution>
</plugin>
And FIPS one:
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<execution>
<id>fips-test</id>
<goals>
<goal>test</goal>
</goals>
<configuration>
<systemPropertyVariables>
<org.apache.wss4j.crypto.jasypt.useLegacyDefaultAlgorithm>false</org.apache.wss4j.crypto.jasypt.useLegacyDefaultAlgorithm>
</systemPropertyVariables>
</configuration>
</execution>
</executions>
</plugin>
More than happy to help with that, it is very difficult to eliminate side effects of system properties in tests, thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Jasypt algorithm changed, for now we'll just use the old encrypted values in the CXF tests until we pick up WSS4J 4.0.2 properly.