Skip to content

[4.1] Fixup Use a properly random source to generate digest client nonces #3452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coheigea merged 1 commit into from
Sep 8, 2026
+16 −2
Merged

[4.1] Fixup Use a properly random source to generate digest client nonces #3452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions rt/transports/http/src/main/java/org/apache/cxf/transport/http/auth/DigestAuthSupplier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@
*
*/
public class DigestAuthSupplier implements HttpAuthSupplier {
private static final SecureRandom CNONCE_GENERATOR = new SecureRandom();
private static volatile SecureRandom cnonceGenerator;
private static final Object CNONCE_GENERATOR_LOCK = new Object();

Map<URI, DigestInfo> authInfo = new ConcurrentHashMap<>();

Expand Down Expand Up @@ -117,7 +118,20 @@ private static String getAuthURI(URI currentURI) {
*/
public String createCnonce() {
byte[] bytes = new byte[16];
CNONCE_GENERATOR.nextBytes(bytes);

SecureRandom cg;
// CHECKSTYLE:OFF
// May the Gods of Code Style forgive us these three inner assignments
if ((cg = cnonceGenerator) == null) {
synchronized (CNONCE_GENERATOR_LOCK) {
if ((cg = cnonceGenerator) == null) {
cg = cnonceGenerator = new SecureRandom();
}
}
}
// CHECKSTYLE:ON

cg.nextBytes(bytes);
return StringUtils.toHexString(bytes);
}

Expand Down
Loading